Review main Merged

82516[FEATURE] Provide workspaces in LiveSearch

Andreas Kienast CR +2 V +2 Normal +171 −0 updated 06/17/24, 06:16

Commit message

When EXT:workspaces is installed, backend users with granted permissions
may now search for workspaces in the LiveSearch and invoke certain,
related actions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Andreas Nedbal +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2736

Show 711 earlier messages
  1. Andreas Kienast uploaded patch set 1 01/19/24, 09:20

  2. core-ci voted on patch set 1 V +1 01/19/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51791

  3. Andreas Kienast uploaded patch set 2 V +1 01/19/24, 10:02

  4. core-ci voted on patch set 2 V +1 01/19/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51799

  5. Andreas Kienast uploaded patch set 3 V +1 01/19/24, 11:11

  6. core-ci voted on patch set 3 V +1 01/19/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51807

  7. Andreas Kienast commented on patch set 3 CR -2 01/23/24, 06:39

  8. Andreas Kienast rebased onto patch set 4 V +1 01/23/24, 09:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. Andreas Kienast voted on patch set 4 CR 0 01/23/24, 09:14

  10. core-ci voted on patch set 4 V +1 01/23/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51973

  11. Chris Müller uploaded patch set 5 V +1 01/30/24, 19:02

  1. core-ci voted on patch set 5 V +1 01/30/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52511

  2. Andreas Kienast uploaded patch set 6 V +1 04/18/24, 10:06

  3. core-ci voted on patch set 6 V +1 04/18/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56249

  4. Andreas Kienast uploaded patch set 7 V +1 04/23/24, 13:00

  5. core-ci voted on patch set 7 V +1 04/23/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56578

  6. Georg Ringer voted on patch set 7 CR +1 V +1 06/10/24, 16:05

  7. Andreas Nedbal voted on patch set 7 CR +1 V +1 06/10/24, 20:19

  8. Mathias Brodala commented on patch set 7 06/11/24, 11:35

    WorkspaceProvider.php:127

    Asking for clarification: will this work fine with arbitrary UTF-8/Unicode characters? And/or languages?
  9. Andreas Nedbal commented on patch set 7 06/11/24, 11:57

    WorkspaceProvider.php:127 Reply

    [php.net on `strtolower()`](https://www.php.net/manual/en/function.strtolower.php): > Bytes in the range "A" (0x41) to "Z" (0x5a) will be converted to the corresponding lowercase letter by adding 32 to each byte value. > > This can be used to convert ASCII characters within strings encoded with UTF-8, since multibyte UTF-8 characters will be ignored. To convert multibyte non-ASCII characters, use mb_strtolower(). So this should work fine.
  10. Andreas Nedbal commented on patch set 7 06/11/24, 12:05

    WorkspaceProvider.php:127 Reply

    My bad, I in parts misinterpreted this and it in fact doesn't work after a quick check of a Workspace name containing a "Ü" and searching for a "ü" in the live search.
  11. Andreas Kienast uploaded patch set 8 CR +1 V +1 06/11/24, 12:08

  12. Andreas Kienast commented on patch set 8 06/11/24, 12:08

    WorkspaceProvider.php:127 Reply

    Thanks, I've fixed this.
  13. core-ci voted on patch set 8 V +1 06/11/24, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59178

  14. Mathias Brodala voted on patch set 8 CR +1 06/11/24, 12:20

  15. Andreas Kienast uploaded patch set 9 CR +1 V +1 06/12/24, 06:48

  16. core-ci voted on patch set 9 V +1 06/12/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59278

  17. Andreas Nedbal voted on patch set 9 CR +1 V +1 06/12/24, 07:04

  18. Mathias Brodala voted on patch set 9 CR +1 06/12/24, 07:07

  19. Jasmina Ließmann voted on patch set 9 V +1 06/12/24, 10:14

  20. Guido Schmechel commented on patch set 9 06/15/24, 15:36

    Basically everything works. Just one small remark

    WorkspaceProvider.php:62

    $this->languageService->sL($this->getFilterLabel()) Or am I missing something?
  21. Andreas Kienast commented on patch set 9 06/15/24, 18:04

    WorkspaceProvider.php:62 Reply

    your proposal would call sL() twice, but I get the idea. I could do that, but there‘s no great benefit.
  22. Guido Schmechel commented on patch set 9 V +1 06/15/24, 18:16

    WorkspaceProvider.php:62 Reply

    Ah right! It shouldn't be me. It was just the prevention of duplicate code. Leave the decision to you.
  23. Andreas Kienast voted on patch set 9 CR +2 V +2 06/17/24, 06:15

  24. Andreas Kienast commented on patch set 9 06/17/24, 06:16

    WorkspaceProvider.php:62 Reply

    Ack, thanks. The API will probably change in a few ways, perhaps this is also solved then.
  25. Andreas Kienast merged patch set 10 06/17/24, 06:16