82516[FEATURE] Provide workspaces in LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Mathias Brodala +1
-
Verified V +2 Done
- Andreas Kienast +2
- Jasmina Ließmann +1
- Andreas Nedbal +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2736
Show 711 earlier messages
-
Andreas Kienast uploaded patch set 1 01/19/24, 09:20
-
core-ci voted on patch set 1 V +1 01/19/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51791
-
Andreas Kienast uploaded patch set 2
V +101/19/24, 10:02 -
core-ci voted on patch set 2 V +1 01/19/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51799
-
Andreas Kienast uploaded patch set 3
V +101/19/24, 11:11 -
core-ci voted on patch set 3 V +1 01/19/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51807
-
Andreas Kienast commented on patch set 3 CR -2 01/23/24, 06:39
Wait for https://review.typo3.org/c/Packages/TYPO3.CMS/+/82592 -
Andreas Kienast rebased onto patch set 4
V +101/23/24, 09:14Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast voted on patch set 4 CR 0 01/23/24, 09:14
-
core-ci voted on patch set 4 V +1 01/23/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51973
-
Chris Müller uploaded patch set 5
V +101/30/24, 19:02
-
core-ci voted on patch set 5 V +1 01/30/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52511
-
Andreas Kienast uploaded patch set 6
V +104/18/24, 10:06 -
core-ci voted on patch set 6 V +1 04/18/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56249
-
Andreas Kienast uploaded patch set 7
V +104/23/24, 13:00 -
core-ci voted on patch set 7 V +1 04/23/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56578
-
Georg Ringer voted on patch set 7 CR +1 V +1 06/10/24, 16:05
-
Andreas Nedbal voted on patch set 7 CR +1 V +1 06/10/24, 20:19
-
Mathias Brodala commented on patch set 7 06/11/24, 11:35
WorkspaceProvider.php:127Asking for clarification: will this work fine with arbitrary UTF-8/Unicode characters? And/or languages? -
Andreas Nedbal commented on patch set 7 06/11/24, 11:57
WorkspaceProvider.php:127Reply[php.net on `strtolower()`](https://www.php.net/manual/en/function.strtolower.php): > Bytes in the range "A" (0x41) to "Z" (0x5a) will be converted to the corresponding lowercase letter by adding 32 to each byte value. > > This can be used to convert ASCII characters within strings encoded with UTF-8, since multibyte UTF-8 characters will be ignored. To convert multibyte non-ASCII characters, use mb_strtolower(). So this should work fine. -
Andreas Nedbal commented on patch set 7 06/11/24, 12:05
WorkspaceProvider.php:127ReplyMy bad, I in parts misinterpreted this and it in fact doesn't work after a quick check of a Workspace name containing a "Ü" and searching for a "ü" in the live search. -
Andreas Kienast uploaded patch set 8
CR +1V +106/11/24, 12:08 -
Andreas Kienast commented on patch set 8 06/11/24, 12:08
WorkspaceProvider.php:127ReplyThanks, I've fixed this. -
core-ci voted on patch set 8 V +1 06/11/24, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59178
-
Mathias Brodala voted on patch set 8 CR +1 06/11/24, 12:20
-
Andreas Kienast uploaded patch set 9
CR +1V +106/12/24, 06:48 -
core-ci voted on patch set 9 V +1 06/12/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59278
-
Andreas Nedbal voted on patch set 9 CR +1 V +1 06/12/24, 07:04
-
Mathias Brodala voted on patch set 9 CR +1 06/12/24, 07:07
-
Jasmina Ließmann voted on patch set 9 V +1 06/12/24, 10:14
-
Guido Schmechel commented on patch set 9 06/15/24, 15:36
Basically everything works. Just one small remarkWorkspaceProvider.php:62$this->languageService->sL($this->getFilterLabel()) Or am I missing something? -
Andreas Kienast commented on patch set 9 06/15/24, 18:04
WorkspaceProvider.php:62Replyyour proposal would call sL() twice, but I get the idea. I could do that, but there‘s no great benefit. -
Guido Schmechel commented on patch set 9 V +1 06/15/24, 18:16
WorkspaceProvider.php:62ReplyAh right! It shouldn't be me. It was just the prevention of duplicate code. Leave the decision to you. -
Andreas Kienast voted on patch set 9 CR +2 V +2 06/17/24, 06:15
-
Andreas Kienast commented on patch set 9 06/17/24, 06:16
WorkspaceProvider.php:62ReplyAck, thanks. The API will probably change in a few ways, perhaps this is also solved then. -
Andreas Kienast merged patch set 10 06/17/24, 06:16