Review main Merged

82519[BUGFIX] Fix page input of recordlist pagination

Oli Bartsch CR +2 V +2 Easy +10 −8 updated 01/21/24, 21:39

Commit message

This fixes several bugs of the recordlist
pagination page input field.

1. The selector for the corresponding form
   element is no longer hardcoded to "pages",
   enabling the field for all tables again.
2. A JavaScript warning regarding "NaN" for
   parseInt() is resolved by using `Number()`.
3. Setting the value is only done in case
   corresponding `min` / `max` settings exist.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/19/24, 13:49

  2. core-ci voted on patch set 1 V +1 01/19/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51819

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 01/19/24, 13:58

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/21/24, 02:33

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 01/21/24, 21:39

  6. Oli Bartsch merged patch set 2 01/21/24, 21:39