82522[!!!][FEATURE] Avoid TSFE->config['config']
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 48
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelDataPersister.php+3 −5
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelRenderer.php+3 −5
- typo3/sysext/adminpanel/Classes/Utility/StateUtility.php2+0 −5
- typo3/sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php+0 −39
- typo3/sysext/core/Classes/Page/DefaultJavaScriptAssetTrait.php+10 −12
- typo3/sysext/core/Classes/PageTitle/PageTitleProviderManager.php+1 −2
- typo3/sysext/core/Classes/TypoScript/AST/Merger/SetupConfigMerger.phpnew+66 −0
- typo3/sysext/core/Classes/TypoScript/FrontendTypoScript.php+81 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102932-RemovedTypoScriptFrontendControllerHooks.rst1new+47 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102932-NewTypoScriptRelatedFrontendEvents.rstnew+35 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Merger/SetupConfigMergerTest.phpnew+299 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ActionViewHelperTest.php+5 −19
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+4 −11
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ActionViewHelperTest.php+1 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −4
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+1 −4
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/TypoScriptServiceTest.php+3 −9
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+8 −13
Show 28 more files
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php+2 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+21 −34
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+186 −184
- typo3/sysext/frontend/Classes/Event/AfterTypoScriptDeterminedEvent.phpnew+50 −0
- typo3/sysext/frontend/Classes/Event/BeforePageCacheIdentifierIsHashedEvent.phpnew+57 −0
- typo3/sysext/frontend/Classes/Event/ModifyTypoScriptConfigEvent.phpnew+69 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+79 −103
- typo3/sysext/frontend/Classes/Middleware/ContentLengthResponseHeader.php+9 −15
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+8 −1
- typo3/sysext/frontend/Classes/Middleware/TimeTrackerInitialization.php+20 −4
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+9 −8
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.php+7 −6
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+4 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+24 −23
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+17 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+75 −40
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+20 −45
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+5 −4
- typo3/sysext/indexed_search/Classes/EventListener/FrontendGenerationPageIndexingTrigger.php+34 −52
- typo3/sysext/indexed_search/Classes/Indexer.php+4 −3
- typo3/sysext/indexed_search/Documentation/DatabaseTables/IndexPhash/Index.rst+1 −2
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+15 −15
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+15 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+2 −1
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+2 −1
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+5 −0
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+55 −63
Review log 61111
Show 4586 earlier messages
-
Christian Kuhn uploaded patch set 1 01/20/24, 11:18
-
core-ci voted on patch set 1 V +1 01/20/24, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51840
-
Christian Kuhn uploaded patch set 2
V +101/21/24, 12:46 -
core-ci voted on patch set 2 V -1 01/21/24, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51889
-
Christian Kuhn uploaded patch set 3
V -101/21/24, 14:30 -
core-ci voted on patch set 3 V -1 01/21/24, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51891
-
Christian Kuhn uploaded patch set 4
V -101/21/24, 15:23 -
core-ci voted on patch set 4 V +1 01/21/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51892
-
Christian Kuhn uploaded patch set 5
V +101/21/24, 15:33 -
core-ci voted on patch set 5 V -1 01/21/24, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51893
-
Christian Kuhn uploaded patch set 6
V -101/21/24, 16:34 -
Christian Kuhn uploaded patch set 7 01/21/24, 16:35
-
core-ci voted on patch set 7 V +1 01/21/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51895
-
Christian Kuhn uploaded patch set 8
V +101/22/24, 10:22 -
core-ci voted on patch set 8 V +1 01/22/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51919
-
Christian Kuhn uploaded patch set 9
V +101/22/24, 10:57 -
core-ci voted on patch set 9 V -1 01/22/24, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51920
-
Christian Kuhn uploaded patch set 10
V -101/22/24, 11:57 -
Christian Kuhn rebased onto patch set 11 01/22/24, 11:57
-
core-ci voted on patch set 10 V +1 01/22/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51925
-
core-ci voted on patch set 11 V +1 01/22/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51926
-
Christian Kuhn updated the commit message in patch set 12
V +101/22/24, 12:04 -
core-ci voted on patch set 12 V +1 01/22/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51930
-
Christian Kuhn uploaded patch set 13
V +101/22/24, 12:53 -
core-ci voted on patch set 13 V -1 01/22/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51933
-
Christian Kuhn uploaded patch set 14
V -101/22/24, 13:05 -
core-ci voted on patch set 14 V +1 01/22/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51934
-
Christian Kuhn uploaded patch set 15
V +101/22/24, 13:25 -
core-ci voted on patch set 15 V -1 01/22/24, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51935
-
Christian Kuhn uploaded patch set 16
V -101/22/24, 13:35 -
core-ci voted on patch set 16 V +1 01/22/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51936
-
Christian Kuhn uploaded patch set 17
V +101/22/24, 13:54 -
core-ci voted on patch set 17 V +1 01/22/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51937
-
Christian Kuhn uploaded patch set 18
V +101/22/24, 14:49 -
core-ci voted on patch set 18 V +1 01/22/24, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51939
-
Christian Kuhn uploaded patch set 19
V +101/22/24, 15:00 -
core-ci voted on patch set 19 V +1 01/22/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51942
-
Christian Kuhn uploaded patch set 20
V +101/22/24, 15:14 -
core-ci voted on patch set 20 V +1 01/22/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51943
-
Christian Kuhn uploaded patch set 21
V +101/23/24, 11:42 -
core-ci voted on patch set 21 V +1 01/23/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51991
-
Christian Kuhn uploaded patch set 22
V +101/23/24, 15:28 -
core-ci voted on patch set 22 V +1 01/23/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52010
-
Christian Kuhn uploaded patch set 23
V +101/23/24, 16:01 -
core-ci voted on patch set 23 V +1 01/23/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52012
-
Christian Kuhn uploaded patch set 24
V +101/23/24, 16:13 -
Christian Kuhn uploaded patch set 25 01/23/24, 16:18
-
core-ci voted on patch set 25 V -1 01/23/24, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52015
-
core-ci voted on patch set 24 V +1 01/23/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52013
-
Christian Kuhn uploaded patch set 26
V -101/24/24, 13:56 -
core-ci voted on patch set 26 V +1 01/24/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52081
-
Christian Kuhn uploaded patch set 27
V +101/24/24, 14:35 -
core-ci voted on patch set 27 V +1 01/24/24, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52085
-
Christian Kuhn uploaded patch set 28
V +101/24/24, 15:03 -
core-ci voted on patch set 28 V -1 01/24/24, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52088
-
Christian Kuhn uploaded patch set 29
V -101/24/24, 15:23 -
Christian Kuhn rebased onto patch set 30 01/24/24, 15:25
-
core-ci voted on patch set 30 V +1 01/24/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52091
-
core-ci voted on patch set 29 V +1 01/24/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52090
-
Christian Kuhn uploaded patch set 31
V +101/24/24, 16:19 -
core-ci voted on patch set 31 V -1 01/24/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52099
-
Christian Kuhn uploaded patch set 32
V -101/24/24, 16:30 -
core-ci voted on patch set 32 V +1 01/24/24, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52100
-
Christian Kuhn uploaded patch set 33
V +101/24/24, 16:43 -
core-ci voted on patch set 33 V -1 01/24/24, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52102
-
Christian Kuhn uploaded patch set 34
V -101/24/24, 17:27 -
Christian Kuhn uploaded patch set 35 01/24/24, 17:27
-
core-ci voted on patch set 35 V -1 01/24/24, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52105
-
Christian Kuhn uploaded patch set 36
V -101/24/24, 17:36 -
core-ci voted on patch set 36 V -1 01/24/24, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52107
-
Christian Kuhn uploaded patch set 37
V -101/24/24, 18:01 -
core-ci voted on patch set 37 V +1 01/24/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52108
-
Christian Kuhn uploaded patch set 38
V +101/25/24, 12:58 -
core-ci voted on patch set 38 V +1 01/25/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52176
-
Christian Kuhn uploaded patch set 39
V +101/25/24, 13:33 -
core-ci voted on patch set 39 V +1 01/25/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52181
-
Christian Kuhn uploaded patch set 40
V +101/25/24, 13:44 -
core-ci voted on patch set 40 V -1 01/25/24, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52182
-
Christian Kuhn uploaded patch set 41
V -101/25/24, 14:29 -
core-ci voted on patch set 41 V +1 01/25/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52185
-
Christian Kuhn uploaded patch set 42
V +101/25/24, 15:19 -
core-ci voted on patch set 42 V +1 01/25/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52186
-
Christian Kuhn uploaded patch set 43
V +101/25/24, 15:31 -
core-ci voted on patch set 43 V +1 01/25/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52189
-
Christian Kuhn uploaded patch set 44
V +101/25/24, 15:42 -
Christian Kuhn uploaded patch set 45 01/25/24, 15:52
-
core-ci voted on patch set 44 V -1 01/25/24, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52190
-
Christian Kuhn uploaded patch set 46 01/25/24, 16:44
-
Christian Kuhn uploaded patch set 47 01/25/24, 16:47
-
Christian Kuhn uploaded patch set 48 01/25/24, 16:52
-
core-ci voted on patch set 46 V -1 01/25/24, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52195
-
core-ci voted on patch set 45 V -1 01/25/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52191
-
core-ci voted on patch set 48 V +1 01/25/24, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52197
-
Christian Kuhn uploaded patch set 49
V +101/25/24, 18:09 -
Christian Kuhn updated the commit message in patch set 50 01/25/24, 18:12
-
Christian Kuhn updated the commit message in patch set 51 01/25/24, 18:16
-
core-ci voted on patch set 49 V +1 01/25/24, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52200
-
core-ci voted on patch set 50 V +1 01/25/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52201
-
core-ci voted on patch set 51 V +1 01/25/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52202
-
Christian Kuhn uploaded patch set 52
V +101/25/24, 18:34 -
core-ci voted on patch set 52 V +1 01/25/24, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52203
-
Benni Mack commented on patch set 52 CR +1 01/25/24, 22:25
impressive. thanks -
Stefan Bürk commented on patch set 52 CR +1 01/25/24, 23:29
again. great work, thx. -
Christian Kuhn uploaded patch set 53
CR +1V +101/26/24, 08:34 -
Benni Mack voted on patch set 53 CR +1 V +1 01/26/24, 08:35
-
core-ci voted on patch set 53 V +1 01/26/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52216
-
Stefan Bürk voted on patch set 53 CR +1 V +1 01/26/24, 09:07
-
Christian Kuhn voted on patch set 53 CR +2 V +2 01/26/24, 09:13
-
Christian Kuhn merged patch set 54 01/26/24, 09:13
-
Benjamin Franzke commented on patch set 54 01/30/24, 14:41
Note: I'm currently updating https://github.com/bnf/nginx_cache for v13.0 and will leave some comments regarding breaking stuff (not mentioned or insufficient replacements here). (I do not complain, I just want them to be mentioned, so we can work on alternatives when doing the subsequent refactorings)StateUtility.php:55Removal is breaking and not mentioned/detected.Breaking-102932-RemovedTypoScriptFrontendControllerHooks.rst:19UnresolvedUsecases for this Hook: Extensions providing cache-proxy integration (like EXT:nginx_cache) With the mentioned alternatives I found following problems: * There is no access to TSFE cache expiry (of the cache content that was loaded from cache) * Ordering against `PrepareTypoScriptFrontendRendering` is @internal * `AfterTypoScriptDeterminedEvent` does not provide context to request (and semantically is strange to be used, if you are interested in the case that page was loaded from cache) * `TSFE->pageContentWasLoadedFromCache` (protected) needs to be accessed to get to know whether the page was actually read from cache (that's what the previous hook said). Alternative: `TSFE->isGeneratePage()` – but that is `@internal` -
Benjamin Franzke commented on patch set 54 01/30/24, 14:42
StateUtility.php:55Reply Unresolved(marking unresolved)