Review main Merged

82527[TASK] Remove extended `SchemaManager::getDatabasePlatform()`

Stefan Bürk CR +2 V +2 Easy +0 −30 updated 01/20/24, 23:21

Commit message

`AbstractSchemaManager::getDatabasePlatform()` is deprecated
and will be remove with Doctrine DBAL 4.x. A intermediate
compat method has been added to the extended `SchemaManager`
classes.

Meanwhile, core internal and testing-framework usages has
been modified and the compatibilty methods are superflous
and will not hit the TYPO3 core directly.

It does not make sense to keep that and extension authors
are able to change there code already with TYPO3 v12 the
removal of these compat methods are not-breaking (yet).

This may be breaking some extensions with Doctrine DBAL 4.x
and will be noticed in the Doctrine DBAL 4.x upgrade change
along with the other breaking changes.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Stefan Bürk uploaded patch set 1 01/20/24, 21:11

  2. Stefan Bürk wrote 01/20/24, 21:11

    Topic set to doctrine-dbal
  3. core-ci voted on patch set 1 V +1 01/20/24, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51857

  4. Oliver Klee voted on patch set 1 CR +1 01/20/24, 21:16

  5. Oliver Klee voted on patch set 1 V +1 01/20/24, 21:18

  6. Benni Mack voted on patch set 1 CR +1 V +1 01/20/24, 21:21

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 01/20/24, 23:20

  8. Stefan Bürk merged patch set 2 01/20/24, 23:21