Review main Merged Breaking

82530[!!!][TASK] Move PackageIcon resolving to package class

Benni Mack CR +2 V +2 Normal +175 −73 updated 01/23/24, 16:51

Commit message

The PackageInterface is now stricly
typed, in addition a new method is added
to the interface "PackageInterface->getPackageIcon()"
thus, deprecating the method
ExtensionManagementUtiliy::getExtensionIcon()

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 914

  1. Benni Mack uploaded patch set 1 01/20/24, 23:35

  2. core-ci voted on patch set 1 V -1 01/20/24, 23:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51863

  3. Benni Mack uploaded patch set 2 V -1 01/22/24, 22:46

  4. core-ci voted on patch set 2 V -1 01/22/24, 22:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51958

  5. Benni Mack uploaded patch set 3 V -1 01/22/24, 22:53

  6. core-ci voted on patch set 3 V +1 01/22/24, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51959

  7. Benni Mack uploaded patch set 4 V +1 01/23/24, 09:57

  8. core-ci voted on patch set 4 V +1 01/23/24, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51978

  9. Christian Kuhn uploaded patch set 5 V +1 01/23/24, 14:32

  10. Christian Kuhn voted on patch set 5 CR +1 V +1 01/23/24, 14:33

  11. core-ci voted on patch set 5 V +1 01/23/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52005

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 01/23/24, 16:50

  13. Stefan Bürk voted on patch set 5 CR +2 V +2 01/23/24, 16:50

  14. Stefan Bürk merged patch set 6 01/23/24, 16:51