Review main Merged

82534[TASK] Remove todo for intExplode function in GeneralUtility

Torben Hansen CR +2 V +2 Easy +1 −2 updated 01/21/24, 19:43

Commit message

A todo for the `intExplode` function suggests to refactor the method
by using `array_filter` and `array_walk`. This refactoring would
however result in more code and slower performance.

The todo is therefore removed, as the function is good as it is.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 01/21/24, 12:53

  2. core-ci voted on patch set 1 V +1 01/21/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51890

  3. Oliver Klee voted on patch set 1 CR +1 V +1 01/21/24, 18:43

  4. Benni Mack voted on patch set 1 CR +2 V +2 01/21/24, 19:43

  5. Benni Mack merged patch set 2 01/21/24, 19:43