Review main Merged

82593[TASK] Use first class closures for service provider factories

Benjamin Franzke CR +2 V +2 Hard +158 −133 updated 02/20/24, 14:02

Commit message

Adapt the service provider compiler to perform the same level of
optimization as for the array-based callable syntax:
We unroll the static closure into its static components (class name and
method name). That means the effective generated dependency injection
php code is the same as before with the gain of better DX.

Note that first class closures can only be used where methods of the
current scope are referenced, late state binding is not supported.
AbstractServiceProvider therefore keeps using array-based callable
syntax to be able to reference method scope of extending classes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 01/23/24, 07:21

  2. core-ci voted on patch set 1 V -1 01/23/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51966

  3. Benjamin Franzke marked it work in progress 01/23/24, 10:25

  4. Benjamin Franzke uploaded patch set 2 V -1 02/13/24, 00:28

  5. core-ci voted on patch set 2 V +1 02/13/24, 00:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53105

  6. Nikita Hovratov voted on patch set 2 CR +1 02/16/24, 19:22

  7. Benni Mack updated the commit message in patch set 3 CR +1 V +1 02/18/24, 21:56

  8. Benni Mack voted on patch set 3 CR +1 V +1 02/18/24, 21:56

  9. core-ci voted on patch set 3 V +1 02/18/24, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53316

  10. Nikita Hovratov voted on patch set 3 CR +1 V +1 02/19/24, 08:03

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/19/24, 08:10

  12. Benjamin Franzke uploaded patch set 4 CR +1 V +1 02/19/24, 08:49

  13. Benjamin Franzke uploaded patch set 5 02/19/24, 08:56

    Revert to patchset3
  14. core-ci voted on patch set 4 V +1 02/19/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53328

  15. core-ci voted on patch set 5 V +1 02/19/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53330

  16. Benni Mack voted on patch set 5 CR +1 V +1 02/19/24, 09:35

  17. Stefan Bürk voted on patch set 5 CR +1 V +1 02/20/24, 14:01

  18. Benjamin Franzke voted on patch set 5 CR +2 V +2 02/20/24, 14:02

  19. Benjamin Franzke merged patch set 6 02/20/24, 14:02