82593[TASK] Use first class closures for service provider factories
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/ServiceProvider.php+14 −14
- typo3/sysext/core/Classes/DependencyInjection/ServiceProviderCompilationPass.php+13 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+63 −63
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProvider.php+8 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+4 −0
- typo3/sysext/dashboard/Classes/ServiceProvider.php+10 −10
- typo3/sysext/extbase/Classes/ServiceProvider.php+5 −5
- typo3/sysext/fluid/Classes/ServiceProvider.php+3 −3
- typo3/sysext/frontend/Classes/ServiceProvider.php+3 −3
- typo3/sysext/install/Classes/ServiceProvider.php+34 −34
Review log 1419
-
Benjamin Franzke uploaded patch set 1 01/23/24, 07:21
-
core-ci voted on patch set 1 V -1 01/23/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51966
-
Benjamin Franzke marked it work in progress 01/23/24, 10:25
-
Benjamin Franzke uploaded patch set 2
V -102/13/24, 00:28 -
core-ci voted on patch set 2 V +1 02/13/24, 00:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53105
-
Nikita Hovratov voted on patch set 2 CR +1 02/16/24, 19:22
-
Benni Mack updated the commit message in patch set 3
CR +1V +102/18/24, 21:56 -
Benni Mack voted on patch set 3 CR +1 V +1 02/18/24, 21:56
-
core-ci voted on patch set 3 V +1 02/18/24, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53316
-
Nikita Hovratov voted on patch set 3 CR +1 V +1 02/19/24, 08:03
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 02/19/24, 08:10
-
Benjamin Franzke uploaded patch set 4
CR +1V +102/19/24, 08:49 -
Benjamin Franzke uploaded patch set 5 02/19/24, 08:56
Revert to patchset3 -
core-ci voted on patch set 4 V +1 02/19/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53328
-
core-ci voted on patch set 5 V +1 02/19/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53330
-
Benni Mack voted on patch set 5 CR +1 V +1 02/19/24, 09:35
-
Stefan Bürk voted on patch set 5 CR +1 V +1 02/20/24, 14:01
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 02/20/24, 14:02
-
Benjamin Franzke merged patch set 6 02/20/24, 14:02