Review main Merged Breaking

82600[!!!][TASK] Remove indexed_search metaphone search

Christian Kuhn CR +2 V +2 Expert +170 −1187 updated 01/23/24, 14:26

Commit message

"Advanced search" Frontend of indexed_search comes
with a "metaphone" / "sounds like" feature.

Its search results are staggeringly bad and the
implementation is a not maintained mess that has
not seen any substantial improvements for 15 years.

The feature seems to be very unused, it seems there
is not even some extension that tries to improve
it, and there are no reports about the incomplete
results one would expect from a proper "metaphone"
implementation. It does not consider UTF-8 in any
way, to name just one issue.

To unblock further indexed_search development that
polish and improve other features, this patch
removes the entire 'metaphone' implementation
together with the Frontend selection, the Backend
statistics, a custom metaphone implementation,
and two database fields.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1013

  1. Christian Kuhn uploaded patch set 1 01/23/24, 13:03

  2. core-ci voted on patch set 1 V +1 01/23/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51998

  3. Andreas Kienast commented on patch set 1 01/23/24, 13:51

    Indexer.php:207

    Comment is superfluous
  4. Christian Kuhn uploaded patch set 2 V +1 01/23/24, 14:10

  5. Christian Kuhn uploaded patch set 3 01/23/24, 14:11

  6. Christian Kuhn commented on patch set 2 01/23/24, 14:11

    Indexer.php:207 Reply

    Done
  7. Benni Mack commented on patch set 3 01/23/24, 14:14

    Just some notes from my side: Metaphone should / could also be implemented on the SQL side. In addition, the PHP code implements Metaphone 2 which has drawbacks. Metaphone 3 is proprietary https://github.com/AtomBoy/double-metaphone
  8. core-ci voted on patch set 2 V +1 01/23/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52002

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 01/23/24, 14:18

  10. core-ci voted on patch set 3 V +1 01/23/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52004

  11. Benni Mack voted on patch set 3 CR +1 V +1 01/23/24, 14:26

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 01/23/24, 14:26

  13. Christian Kuhn merged patch set 4 01/23/24, 14:26