82600[!!!][TASK] Remove indexed_search metaphone search
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 23
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102900-MetaphoneSearchRemovedFromIndexed_search.rstnew+70 −0
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −21
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+0 −22
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −29
- typo3/sysext/indexed_search/Classes/Service/DatabaseSchemaService.php+0 −2
- typo3/sysext/indexed_search/Classes/Type/SearchType.php+0 −1
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.phpdeleted+0 −859
- typo3/sysext/indexed_search/Classes/Indexer.php2+0 −84
- typo3/sysext/indexed_search/Documentation/Introduction/Index.rst+2 −2
- typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf+0 −9
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_em.xlf+0 −3
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+0 −37
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/indexing_words_twice_first.csv+5 −5
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/indexing_words_twice_second.csv+5 −5
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/index_dataset.csv+70 −70
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/phash_collision.csv+4 −4
- typo3/sysext/indexed_search/Tests/Functional/IndexSearchRepositoryTest.php+0 −12
- typo3/sysext/indexed_search/ext_conf_template.txt+0 −3
- typo3/sysext/indexed_search/ext_localconf.php+0 −5
Review log 1013
-
Christian Kuhn uploaded patch set 1 01/23/24, 13:03
-
core-ci voted on patch set 1 V +1 01/23/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51998
-
Andreas Kienast commented on patch set 1 01/23/24, 13:51
-
Christian Kuhn uploaded patch set 2
V +101/23/24, 14:10 -
Christian Kuhn uploaded patch set 3 01/23/24, 14:11
-
Christian Kuhn commented on patch set 2 01/23/24, 14:11
Indexer.php:207ReplyDone -
Benni Mack commented on patch set 3 01/23/24, 14:14
Just some notes from my side: Metaphone should / could also be implemented on the SQL side. In addition, the PHP code implements Metaphone 2 which has drawbacks. Metaphone 3 is proprietary https://github.com/AtomBoy/double-metaphone -
core-ci voted on patch set 2 V +1 01/23/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52002
-
Andreas Kienast voted on patch set 3 CR +1 V +1 01/23/24, 14:18
-
core-ci voted on patch set 3 V +1 01/23/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52004
-
Benni Mack voted on patch set 3 CR +1 V +1 01/23/24, 14:26
-
Christian Kuhn voted on patch set 3 CR +2 V +2 01/23/24, 14:26
-
Christian Kuhn merged patch set 4 01/23/24, 14:26
Indexer.php:207