Review main Merged

82603[DOCS] Improve output of *rootPaths examples

TYPO3com CR +2 V +2 Easy +20 −12 updated 01/23/24, 18:32

Commit message

Maybe there is also a better way to display this? Currently the line
breaks aren't visible, which makes it quite hard to understand.

https://docs.typo3.org/c/typo3/cms-form/main/en-us/D/FrontendRendering/Index.html

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Chris Müller +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. TYPO3com uploaded patch set 1 01/23/24, 15:59

  2. core-ci voted on patch set 1 V +1 01/23/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52011

  3. Chris Müller commented on patch set 1 CR +1 V +1 01/23/24, 17:14

    Fine for me. There may be other possibilities, like a list and then format the snippets accordingly. But this improves readability a lot now.
  4. Chris Müller updated the commit message in patch set 2 CR +1 V +1 01/23/24, 17:15

  5. Chris Müller voted on patch set 2 CR +1 V +1 01/23/24, 17:15

  6. core-ci voted on patch set 2 V +1 01/23/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52022

  7. Nikita Hovratov commented on patch set 2 01/23/24, 17:28

    I think we should backport this at least for v12?
    Should be [DOCS]
  8. Chris Müller updated the commit message in patch set 3 CR +1 V +1 01/23/24, 17:43

  9. Chris Müller commented on patch set 3 CR +1 V +1 01/23/24, 17:43

    Reply

    Done

    Reply

    Done
  10. core-ci voted on patch set 3 V +1 01/23/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52025

  11. Nikita Hovratov voted on patch set 3 CR +2 V +2 01/23/24, 18:32

  12. Nikita Hovratov merged patch set 4 01/23/24, 18:32