Review main Merged Breaking

82606[!!!][TASK] Use typolink to build links to pages in Indexed Search

Benni Mack CR +2 V +2 Normal +69 −150 updated 01/24/24, 10:17

Commit message

By working with the LinkResult object, and LinkFactory
APIs, Indexed Search does now generate proper links
to pages as expected, and with sane defaults in regards
to ATagParams etc, which can be modified by the
central Event system in PageLinkBuilder APIs.

For this reason, the TypoScript settings

plugin.tx_indexedsearch.settings.detectDomainRecords
plugin.tx_indexedsearch.settings.detectDomainRecords.target

are removed, as the link generation follows the same
rules as for regular links in menus or content (a.k.a.
typolink knows exactly when to use a full domain or
just an absolute path).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 711

  1. Benni Mack uploaded patch set 1 01/23/24, 20:08

  2. core-ci voted on patch set 1 V -1 01/23/24, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52037

  3. Benni Mack uploaded patch set 2 V -1 01/23/24, 20:41

  4. core-ci voted on patch set 2 V +1 01/23/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52044

  5. Benni Mack uploaded patch set 3 V +1 01/23/24, 20:51

  6. Benni Mack updated the commit message in patch set 4 01/23/24, 20:52

  7. core-ci voted on patch set 3 V +1 01/23/24, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52045

  8. core-ci voted on patch set 4 V +1 01/23/24, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52046

  9. Andreas Kienast voted on patch set 4 CR +1 V +1 01/24/24, 06:46

  10. Christian Kuhn voted on patch set 4 CR +2 V +2 01/24/24, 10:17

  11. Christian Kuhn merged patch set 5 01/24/24, 10:17