82607[TASK] Indexed Search: Use DTOs for indexing data
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stephan Großberndt +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102908-IndexedSearchContentParsersReturningArrays.rst4new+66 −0
- typo3/sysext/indexed_search/Classes/Dto/IndexingDataAsArray.phpnew+51 −0
- typo3/sysext/indexed_search/Classes/Dto/IndexingDataAsString.phpnew+49 −0
- typo3/sysext/indexed_search/Classes/FileContentParser.php4+34 −33
- typo3/sysext/indexed_search/Classes/Indexer.php12+100 −105
Review log 1518
-
Andreas Kienast uploaded patch set 1 01/24/24, 07:44
-
core-ci voted on patch set 1 V +1 01/24/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52055
-
Stephan Großberndt commented on patch set 1 01/24/24, 08:15
-
Garvin Hicking commented on patch set 1 01/24/24, 08:21
Deprecation-102908-IndexedSearchContentParsersReturningArrays.rst:15"return a solely defined array for" -> "return an array solely defined for"Deprecation-102908-IndexedSearchContentParsersReturningArrays.rst:22Probably better "deprecated" to properly indicate the future removal of this?FileContentParser.php:526Maybe rename this variable to $contentObj (or $indexContent, $contentData...) or so? It's no longer an array so this might "read better"? In the other file most instances got replaced with "indexingDataDto", that could match here too?Indexer.php:343Maybe preserve that cross-reference?Indexer.php:900Can typehints for the other parameters be added too, or probably beyond the scope of this patch?Indexer.php:970Maybe this explanation can be preserved as a phpdoc method comment? -
Andreas Kienast commented on patch set 1 01/24/24, 08:29
Deprecation-102908-IndexedSearchContentParsersReturningArrays.rst:15ReplyAcknowledgedDeprecation-102908-IndexedSearchContentParsersReturningArrays.rst:22ReplyAcknowledgedFileContentParser.php:461ReplyI'll re-add the phpdoc for now. IMO(!) this should be proper exceptions.FileContentParser.php:526ReplyAcknowledgedIndexer.php:343ReplyWe usually don't do these cross-references anymore. Also, there are some more refactorings in the pipeline.Indexer.php:900ReplyAcknowledgedIndexer.php:970ReplyThe comment doesn't make much sense in it's current state. It describes that all values are "not a unique array of words", but that's in fact quite the opposite the method does. -
Andreas Kienast uploaded patch set 2
V +101/24/24, 08:30 -
Stephan Großberndt voted on patch set 2 CR +1 01/24/24, 08:32
-
Stephan Großberndt commented on patch set 2 CR 0 01/24/24, 08:35
Indexer.php:145This still says arrayIndexer.php:147Maybe rename this one as well? -
core-ci voted on patch set 2 V +1 01/24/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52058
-
Andreas Kienast uploaded patch set 3
V +101/24/24, 08:46 -
Andreas Kienast commented on patch set 3 01/24/24, 08:46
Indexer.php:145ReplyDoneIndexer.php:147ReplyDone -
core-ci voted on patch set 3 V +1 01/24/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52059
-
Stephan Großberndt voted on patch set 3 CR +1 01/24/24, 08:55
-
Garvin Hicking commented on patch set 3 CR +1 V +1 01/24/24, 09:00
Thanks for giving this old lad some love. ;) -
Stefan Bürk commented on patch set 3 01/24/24, 09:04
Indexer.php:139Should this not be initialized to a instance in the constructor ? Otherwise an access befor setting it (and that counts checking for existens) would fail. Or at least marked as nullable and properly handled at places ? The other point - does it really need to be public ? -
Benni Mack voted on patch set 3 CR +2 V +2 01/24/24, 09:04
-
Benni Mack merged patch set 4 01/24/24, 09:04
-
Benni Mack commented on patch set 4 01/24/24, 09:05
Indexer.php:139Replyah, sorry, did not see the comment while submitting it. Yes, it needs to be public for the time being as the Indexer API is de-facto non-existent, I hope this gets improved in the next few patches
FileContentParser.php:461