Review main Merged

82608[BUGFIX] Indexed Search: Only write internal log if `debugMode` is enabled

Andreas Kienast CR +2 V +2 Easy +5 −8 updated 01/24/24, 09:00

Commit message

The `Indexer` class from Indexed Search has an `internal_log` property
that's only accessed when `debugMode` is enabled.

However, the wrapper method `log_setTSlogMessage()` always writes into
the log, which doesn't make much sense. Said method now checks for
enabled debugging before writing into the log property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stephan Großberndt +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Andreas Kienast uploaded patch set 1 01/24/24, 07:51

  2. core-ci voted on patch set 1 V +1 01/24/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52056

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/24/24, 08:01

  4. Stephan Großberndt voted on patch set 1 CR +1 01/24/24, 08:03

  5. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 01/24/24, 08:10

  6. Stephan Großberndt voted on patch set 2 CR +1 01/24/24, 08:11

  7. core-ci voted on patch set 2 V +1 01/24/24, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52057

  8. Daniel Siepmann voted on patch set 2 CR +1 01/24/24, 08:29

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 01/24/24, 08:33

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 01/24/24, 08:51

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 01/24/24, 08:55

  12. Andreas Kienast merged patch set 3 01/24/24, 09:00