Review 11.5 Merged

82617[BUGFIX] Do not resolve resource paths in EXT:form

Peter Kraume CR +2 V +2 Normal +6 −78 updated 01/25/24, 12:00

Commit message

The method resolveResourcePaths() is superfluous because the
PageRenderer resolves path with EXT: later with
getStreamlinedFileName() anyway.
Furthermore this patch resolves open_basedir errors. As a plus,
the form.css gets a version numbered filename now which mitigates
caching issues.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Peter Kraume commented on patch set 1 01/25/24, 11:03

    Cherry Picked from branch 12.4. The following files contain Git conflicts: * typo3/sysext/form/Classes/Controller/AbstractBackendController.php * typo3/sysext/form/Classes/Controller/FormManagerController.php * typo3/sysext/form/Tests/Unit/Controller/AbstractBackendControllerTest.php
  2. Peter Kraume uploaded patch set 2 01/25/24, 11:14

  3. core-ci voted on patch set 1 V -1 01/25/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52155

  4. Peter Kraume marked it ready for review 01/25/24, 11:17

  5. core-ci voted on patch set 2 V -1 01/25/24, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52158

  6. Peter Kraume rebased onto patch set 3 V -1 01/25/24, 11:37

  7. Oliver Hader voted on patch set 3 CR +1 V +1 01/25/24, 11:40

  8. core-ci voted on patch set 3 V +1 01/25/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52163

  9. Oliver Hader voted on patch set 3 CR +2 V +2 01/25/24, 12:00

  10. Oliver Hader merged patch set 4 01/25/24, 12:00