Review 12.4 Merged

82620[TASK] Improve type annotations for (Lazy)ObjectStorage

Christian Kuhn CR +2 V +2 Easy +23 −21 updated 01/28/24, 12:35

Commit message

Make proper use of generics and align the API of our classes
with that of the implemented interfaces `Iterator` and
`ArrayAccess`.

This helps extension developers use static analysis for their
extensions.

This is a pre-patch to introducing native types for the two
classes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Christian Kuhn commented on patch set 1 01/28/24, 11:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/28/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52358

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 01/28/24, 12:35

  4. Christian Kuhn merged patch set 2 01/28/24, 12:35