Review main Merged

82635[BUGFIX] Do not resolve resource paths in EXT:form

Peter Kraume CR +2 V +2 Normal +6 −93 updated 01/25/24, 10:34

Commit message

The method resolveResourcePaths() is superfluous because the
PageRenderer resolves path with EXT: later with
getStreamlinedFileName() anyway.
Furthermore this patch resolves open_basedir errors. As a plus,
the form.css gets a version numbered filename now which mitigates
caching issues.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1318

  1. Peter Kraume uploaded patch set 1 01/24/24, 16:05

  2. core-ci voted on patch set 1 V -1 01/24/24, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52096

  3. Peter Kraume uploaded patch set 2 V -1 01/24/24, 16:13

  4. core-ci voted on patch set 2 V +1 01/24/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52098

  5. Oliver Hader commented on patch set 2 01/24/24, 16:56

    AbstractBackendController.php:67

    Even if this class is marked `@internal`, we should keep the method in existing stable branches for backward compatibility reasons - but just with `return $return;`
  6. Peter Kraume uploaded patch set 3 01/25/24, 09:06

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  7. Peter Kraume commented on patch set 3 01/25/24, 09:07

    AbstractBackendController.php:67 Reply

    Done
  8. Peter Kraume uploaded patch set 4 V +1 01/25/24, 09:08

  9. core-ci voted on patch set 4 V +1 01/25/24, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52142

  10. core-ci voted on patch set 3 V +1 01/25/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52141

  11. Peter Kraume uploaded patch set 5 V +1 01/25/24, 10:11

  12. core-ci voted on patch set 5 V +1 01/25/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52149

  13. Oliver Hader voted on patch set 5 CR +1 V +1 01/25/24, 10:21

  14. Oliver Hader commented on patch set 5 01/25/24, 10:24

    AbstractBackendController.php:57

    Note to other reviewers: Since this class in `@internal` it's fine, to not mark this as deprecated with corresponding RST-file etc. But for v13, the removal should be emphasized and probably scanned.
  15. Benni Mack voted on patch set 5 CR +1 V +1 01/25/24, 10:33

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 01/25/24, 10:34

  17. Oliver Hader voted on patch set 5 CR +2 V +2 01/25/24, 10:34

  18. Oliver Hader merged patch set 6 01/25/24, 10:34