Review main Merged Breaking

82636[!!!][TASK] Remove `ExpressionBuilder::trim()` deprecation

Stefan Bürk CR +2 V +2 Normal +63 −24 updated 01/25/24, 07:49

Commit message

With #102875 Doctrine DBAL 4.x has been added which was a
task over a longer time. Originally planned to deprecate
changes the later decision was to pass Doctrine breaking
changes directly.

It has been missed to remove the `ExpressionBuilder::trim()`
deprecation for the integer TrimMode and the mitigation for
it.

This change now removes the deprecation and directly allows
only the Doctrine DBAL TrimMode enum.

[1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-converted-enum-like-classes-to-enums

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3