Review main Merged

82640[TASK] Update PHPStan and friends

Stefan Bürk CR +2 V +2 Easy +19 −17 updated 01/25/24, 06:55

Commit message

This change updates phpstan and related
libraries to available maximum versions.

The new version finds two `array_filter`
usages with wrong typeing, which is fixed
along the way.

Used command(s):

> composer require --dev \
    "phpstan/phpstan":"^1.10.57" \
    "phpstan/phpdoc-parser":"^1.25.0" \
    "phpstan/phpstan-phpunit":"^1.3.15"

> Build/Scripts/runTests.sh -s phpstan

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Stefan Bürk uploaded patch set 1 01/25/24, 06:21

  2. core-ci voted on patch set 1 V -1 01/25/24, 06:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52124

  3. Stefan Bürk uploaded patch set 2 V -1 01/25/24, 06:29

  4. core-ci voted on patch set 2 V +1 01/25/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52127

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 01/25/24, 06:44

  6. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 01/25/24, 06:44

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 01/25/24, 06:44

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/25/24, 06:47

  9. core-ci voted on patch set 3 V +1 01/25/24, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52128

  10. Anja Leichsenring voted on patch set 3 CR +2 V +2 01/25/24, 06:55

  11. Anja Leichsenring merged patch set 4 01/25/24, 06:55