Review 12.4 Merged

82641[TASK] Update PHPStan and friends

Stefan Bürk CR +2 V +2 Easy +18 −15 updated 01/25/24, 07:34

Commit message

This change updates phpstan and related
libraries to available maximum versions.

The new version finds one `array_filter`
usages with wrong typeing, which is fixed
along the way.

Used command(s):

> composer require --dev \
    "phpstan/phpstan":"^1.10.57" \
    "phpstan/phpdoc-parser":"^1.25.0" \
    "phpstan/phpstan-phpunit":"^1.3.15"

> Build/Scripts/runTests.sh -s phpstan

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Stefan Bürk uploaded patch set 1 01/25/24, 06:27

  2. Stefan Bürk uploaded patch set 2 01/25/24, 06:28

  3. core-ci voted on patch set 1 V -1 01/25/24, 06:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52125

  4. core-ci voted on patch set 2 V +1 01/25/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52126

  5. Andreas Kienast updated the commit message in patch set 3 V +1 01/25/24, 06:46

  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/25/24, 06:47

  7. core-ci voted on patch set 3 V +1 01/25/24, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52129

  8. Anja Leichsenring voted on patch set 3 CR +2 V +2 01/25/24, 07:34

  9. Anja Leichsenring merged patch set 4 01/25/24, 07:34