Review main Merged Breaking

82642[!!!][TASK] Remove several outdated Indexed Search options

Benni Mack CR +2 V +2 Hard +62 −416 updated 01/25/24, 09:44

Commit message

This change removes various functionality
within Indexed Search which was partly kept
when migrating the plugin towards Extbase
back in TYPO3 v6.2, but serve no real purpose
anymore:

- CSSsuffix
- specialConfiguration
- iconRendering
- flagRendering

This functionality is nowadays represented
within the actual View rendering, thus
the TypoScript options can be removed, as
Fluid is much more powerful than the old
marker-based templating approach.

In addition, the feature to choose a specific
language within the search is removed,
as this functionality is not viable in modern
sites (example: when searching on a french
website, search should not find japanese
results).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 813

  1. Benni Mack uploaded patch set 1 01/25/24, 08:14

  2. Benni Mack commented on patch set 2 01/25/24, 08:14

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 01/25/24, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52135

  4. core-ci voted on patch set 2 V -1 01/25/24, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52136

  5. Benni Mack uploaded patch set 3 V -1 01/25/24, 08:27

  6. core-ci voted on patch set 3 V +1 01/25/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52137

  7. Benni Mack uploaded patch set 4 V +1 01/25/24, 08:50

  8. Andreas Kienast uploaded patch set 5 01/25/24, 08:55

  9. core-ci voted on patch set 4 V +1 01/25/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52139

  10. core-ci voted on patch set 5 V +1 01/25/24, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52140

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 01/25/24, 09:08

  12. Georg Ringer voted on patch set 5 CR +2 V +2 01/25/24, 09:44

  13. Georg Ringer merged patch set 6 01/25/24, 09:44