82647[TASK] Use cleaner check for MySQL fulltext in search
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1115
-
Benni Mack uploaded patch set 1 01/25/24, 11:39
-
Benni Mack uploaded patch set 2 01/25/24, 11:39
-
core-ci voted on patch set 1 V -1 01/25/24, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52164
-
Christian Kuhn commented on patch set 2 01/25/24, 11:45
-
core-ci voted on patch set 2 V +1 01/25/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52165
-
Benni Mack commented on patch set 2 01/25/24, 11:53
IndexedSearchUtility.php:163ReplyCurrently I see this as an in-between solution, once we are done with the major cleanups, we could use the Repositories and Controllers to use DI and inject the information then directly. The Utility is internal anyways and will hopefully vanish once we go into smaller PHP classes. these are all monsters. -
Benni Mack uploaded patch set 3
V +101/25/24, 12:37 -
core-ci voted on patch set 3 V -1 01/25/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52173
-
Benni Mack uploaded patch set 4
V -101/25/24, 13:10 -
core-ci voted on patch set 4 V +1 01/25/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52177
-
Stefan Bürk commented on patch set 4 CR +1 V +1 01/25/24, 13:27
IndexedSearchUtility.php:163ReplyAlbeit basically on lolli's track, I'm fine with a intermediate solution for now - and as a intermediate `understanding` change for a eventually more deeper refactoring. -
Benni Mack commented on patch set 4 01/25/24, 15:27
IndexedSearchUtility.php:163ReplyI am also lolli's track, but I prefer to do this at a later stage. -
Jochen Roth voted on patch set 4 CR +1 V +1 01/25/24, 16:49
-
Christian Kuhn voted on patch set 4 CR +2 V +2 01/25/24, 18:35
-
Christian Kuhn merged patch set 5 01/25/24, 18:35
IndexedSearchUtility.php:163