82650[!!!][FEATURE] Add PSR-14 PackageInitializationEvent
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 35
- Build/phpstan/phpstan-baseline.neon+5 −5
- typo3/sysext/core/Classes/Command/SetupExtensionsCommand.php2renamed+25 −15
- typo3/sysext/core/Classes/Package/Event/PackageInitializationEvent.phpnew+85 −0
- typo3/sysext/core/Classes/Package/Exception/ImportRequirementsException.phpnew+25 −0
- typo3/sysext/core/Classes/Package/Exception/InvalidPackageInitializationResultIdentifierException.phpnew+25 −0
- typo3/sysext/core/Classes/Package/Initialization/CheckForImportRequirements.phpnew+92 −0
- typo3/sysext/core/Classes/Package/Initialization/ImportExtensionDataOnPackageInitialization.phpnew+53 −0
- typo3/sysext/core/Classes/Package/Initialization/ImportStaticSqlDataOnPackageInitialization.phpnew+61 −0
- typo3/sysext/core/Classes/Package/PackageActivationService.phpnew+119 −0
- typo3/sysext/core/Classes/Package/PackageInitializationResult.phpnew+39 −0
- typo3/sysext/core/Configuration/Services.yaml+10 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102935-OverhauledExtensionInstallationInExtensionManager.rstnew+96 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102935-PSR-14EventForPackageInitializationFunctionality.rstnew+98 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/Initialisation/Files/logos/typo3.svgnew+6 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/Initialisation/Site/demo/config.yamlnew+16 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/Initialisation/data.xmlnew+13 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_package_initialization/ext_tables_static+adt.sqlnew+8 −0
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.phpnew+163 −0
Show 15 more files
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php2+4 −9
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionDatabaseContentHasBeenImportedEvent.phpdeleted+0 −53
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionFilesHaveBeenImportedEvent.phpdeleted+0 −47
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionSiteFilesHaveBeenImportedEvent.phpdeleted+0 −48
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionStaticDatabaseContentHasBeenImportedEvent.phpdeleted+0 −47
- typo3/sysext/extensionmanager/Classes/Initialization/DispatchAfterPackageActivationEventOnPackageInitialization.phpnew+49 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+3 −2
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+8 −242
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Configuration/Services.yaml+0 −7
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+2 −2
- typo3/sysext/impexp/Classes/Initialization/ImportContentOnPackageInitialization.phpnew+82 −0
- typo3/sysext/impexp/Classes/Initialization/ImportSiteConfigurationsOnPackageInitialization.phpnew+115 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+24 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+8 −1
Review log 2640
Show 915 earlier messages
-
Oli Bartsch uploaded patch set 1 01/25/24, 23:25
-
core-ci voted on patch set 1 V -1 01/25/24, 23:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52207
-
Oli Bartsch uploaded patch set 2
V -101/26/24, 08:18 -
core-ci voted on patch set 2 V +1 01/26/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52213
-
Oli Bartsch uploaded patch set 3
V +101/26/24, 22:45 -
Oli Bartsch uploaded patch set 4 01/26/24, 22:49
-
core-ci voted on patch set 3 V -1 01/26/24, 22:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52272
-
Oli Bartsch uploaded patch set 5 01/26/24, 23:01
-
core-ci voted on patch set 4 V -1 01/26/24, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52273
-
core-ci voted on patch set 5 V +1 01/26/24, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52274
-
Benni Mack commented on patch set 5 01/26/24, 23:14
-
Oli Bartsch uploaded patch set 6
V +101/26/24, 23:39 -
core-ci voted on patch set 6 V -1 01/26/24, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52275
-
Oli Bartsch updated the commit message in patch set 7
V -101/27/24, 00:00 -
Oli Bartsch commented on patch set 7 01/27/24, 00:00
ActionController.php:168ReplyDone
-
Oli Bartsch uploaded patch set 8 01/27/24, 00:01
-
core-ci voted on patch set 7 V -1 01/27/24, 00:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52276
-
core-ci voted on patch set 8 V +1 01/27/24, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52277
-
Oli Bartsch uploaded patch set 9
V +101/27/24, 08:29 -
core-ci voted on patch set 9 V +1 01/27/24, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52283
-
Oli Bartsch uploaded patch set 10
V +101/27/24, 10:23 -
core-ci voted on patch set 10 V +1 01/27/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52284
-
Simon Schaufelberger commented on patch set 10 01/27/24, 13:11
SetupExtensionsCommand.php:18Why is this moved to core? Setting up extensions is a responsibility of the extension manager, or? Be aware that this command is heavily used in typo3 console and other applications like surf!!! -
Christian Kuhn commented on patch set 10 CR -1 01/27/24, 18:54
on it. -
Christian Kuhn commented on patch set 10 01/27/24, 18:57
SetupExtensionsCommand.php:18Replythis is not about loading / unloading extensions, but about setting them up. the deal ist: EM is for non-composer. Stuff that needs to be done in composer mode as well, should be part of the core. this allows unloading EM in composer mode. Thus the patch. Clarified this in the commit message now. -
Christian Kuhn uploaded patch set 11
CR -1V +101/27/24, 19:09 -
core-ci voted on patch set 11 V +1 01/27/24, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52319
-
Christian Kuhn uploaded patch set 12
V +101/27/24, 20:19 -
Simon Schaufelberger voted on patch set 12 CR +1 01/27/24, 20:22
-
core-ci voted on patch set 12 V +1 01/27/24, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52328
-
Benni Mack updated the commit message in patch set 13
CR +1V +101/27/24, 21:32 -
core-ci voted on patch set 13 V +1 01/27/24, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52332
-
Benni Mack commented on patch set 13 01/27/24, 22:55
We use AE (except for a few places), thus we use "initialize" instead of "initialise" in 1200+ places already. I would recommend to rename the event as such -
Oli Bartsch uploaded patch set 14
V +101/28/24, 11:41 -
Oli Bartsch commented on patch set 14 01/28/24, 11:46
Reply
Actually the whole initialization functionality for static data, assets, sites, etc. uses the ext/Initialisation/* directory. However, reworked the patch to always use AE except for the directory references. -
core-ci voted on patch set 14 V +1 01/28/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52356
-
Benni Mack voted on patch set 14 CR +1 V +1 01/28/24, 12:30
-
Christian Kuhn voted on patch set 14 CR +1 V +1 01/28/24, 12:36
-
Oli Bartsch voted on patch set 14 CR +2 V +2 01/28/24, 15:26
-
Oli Bartsch merged patch set 15 01/28/24, 15:26
ActionController.php:168