Review main Merged

82654[TASK] Improve Install Tool UX for first-time users

Mathias Bolt Lesniak CR +2 V +2 Easy +23 −8 updated 01/26/24, 18:48

Commit message

Specifically mention FIRST_INSTALL file and recommend new users to read the Getting Started documentation at docs.typo3.org when warning that the Install Tool is locked.

Also adds an info box with a similar documentation recommendation to new users.

This ensures that new users always get directed to the documentation and that new users are told about the FIRST_INSTALL file, also if TYPO3 doesn't detect a new installation.

Also fixes some minor grammar.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1923

  1. Mathias Bolt Lesniak uploaded patch set 1 01/26/24, 10:08

  2. Mathias Bolt Lesniak rebased onto patch set 2 01/26/24, 10:10

  3. core-ci voted on patch set 1 V +1 01/26/24, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52225

  4. core-ci voted on patch set 2 V +1 01/26/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52226

  5. Albrecht Köhnlein commented on patch set 2 01/26/24, 10:23

    ShowInstallerNotAvailable.html:16

    Have you thought about directly linking to https://docs.typo3.org/Home/GettingStarted.html ? Or are you afraid, the URL might change in future?
  6. Stefan Bürk commented on patch set 2 01/26/24, 10:24

    ShowInstallerNotAvailable.html:16

    ShowEnableInstallToolFile.html:18

    Getting started is mentiond but not directly linked. Why not linking directly to `https://docs.typo3.org/Home/GettingStarted.html#getting-started` ?
  7. Mathias Bolt Lesniak commented on patch set 2 01/26/24, 10:27

    ShowInstallerNotAvailable.html:16 Reply

    I was afraid it might change. It's anyway very visible directly on the home page, so I decided to let the fear take the upper hand. I can change if you recommend it.

    ShowInstallerNotAvailable.html:16 Reply

    Yup, was afraid it might change. It's anyway very visible directly on the home page, so I decided to let the fear take the upper hand. I can change if you recommend it.

    ShowEnableInstallToolFile.html:18 Reply

    I was afraid it might change. It's anyway very visible directly on the home page, so I decided to let the fear take the upper hand. I can change if you recommend it.
  8. Albrecht Köhnlein commented on patch set 2 01/26/24, 11:00

    ShowInstallerNotAvailable.html:16 Reply

    I would prefer to use the full URL (And in case it will change some day, the documentation team should ensure to have proper redirects. But that's another topic.)
  9. Mathias Bolt Lesniak uploaded patch set 3 V +1 01/26/24, 12:09

  10. Mathias Bolt Lesniak commented on patch set 3 01/26/24, 12:11

    ShowInstallerNotAvailable.html:16 Reply

    Based on Albrecht Könlein's feedback, I have updated the URL in patchset 3.

    ShowInstallerNotAvailable.html:16 Reply

    I have updated the URL in patchset 3.

    ShowEnableInstallToolFile.html:18 Reply

    Based on Albrecht Könlein's feedback, I have updated the URL in patchset 3.
  11. core-ci voted on patch set 3 V +1 01/26/24, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52244

  12. Stefan Bürk voted on patch set 3 CR +1 V +1 01/26/24, 12:17

  13. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/26/24, 12:19

  14. Andreas Kienast voted on patch set 3 CR +1 01/26/24, 14:56

  15. Nikita Hovratov voted on patch set 3 CR +1 V +1 01/26/24, 16:02

  16. Oliver Hader voted on patch set 3 CR -1 01/26/24, 16:13

  17. Oliver Hader commented on patch set 4 CR +1 V +1 01/26/24, 16:14

    Published edit on patch set 3.
  18. Oliver Hader voted on patch set 4 CR +1 01/26/24, 16:15

  19. core-ci voted on patch set 4 V +1 01/26/24, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52263

  20. Nikita Hovratov voted on patch set 4 CR +1 V +1 01/26/24, 17:42

  21. Christian Kuhn voted on patch set 4 CR +1 V +1 01/26/24, 18:06

  22. Nikita Hovratov voted on patch set 4 CR +2 V +2 01/26/24, 18:48

  23. Nikita Hovratov merged patch set 5 01/26/24, 18:48