82656[TASK] Use TCA and db defaults for auto-created redirect
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Guido Schmechel +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Guido Schmechel +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1419
-
Stefan Bürk uploaded patch set 1 01/26/24, 10:48
-
Stefan Bürk uploaded patch set 2 01/26/24, 10:52
-
core-ci voted on patch set 1 V -1 01/26/24, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52230
-
core-ci voted on patch set 2 V -1 01/26/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52231
-
Stefan Bürk uploaded patch set 3
V -101/26/24, 11:16 -
core-ci voted on patch set 3 V +1 01/26/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52233
-
Stefan Bürk rebased onto patch set 4
V +101/26/24, 12:47 -
core-ci voted on patch set 4 V +1 01/26/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52248
-
Oliver Klee voted on patch set 4 V +1 01/27/24, 13:37
-
Guido Schmechel commented on patch set 4 CR +1 V +1 01/27/24, 20:12
Successfully tested with respect_query_parameters via a TCA change. target_statuscode did not run via TCA because there is a separate setting for it: $this->httpStatusCode = (int)$settings->get('redirects.httpStatusCode', 307); Do we need to mention this in your new comment? -
Stefan Bürk uploaded patch set 5
CR +1V +101/27/24, 20:58 -
Stefan Bürk commented on patch set 4 01/27/24, 21:01
Reply
Removed the comment as it is solved by this change. It's mentioned in the commit message > before applying the SiteConfiguration setting, manual defaults and dispatching the redirect event `ModifyAutoCreateRedirectRecordBeforePersistingEvent` -
core-ci voted on patch set 5 V +1 01/27/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52330
-
Oliver Klee voted on patch set 5 V +1 01/27/24, 21:08
-
Guido Schmechel voted on patch set 5 CR +1 V +1 01/27/24, 21:37
-
Oliver Klee voted on patch set 5 CR +1 01/27/24, 21:45
-
Nikita Hovratov voted on patch set 5 CR +1 V +1 01/28/24, 16:58
-
Stefan Bürk voted on patch set 5 CR +2 V +2 01/29/24, 11:43
-
Stefan Bürk merged patch set 6 01/29/24, 11:43