Review main Merged

82656[TASK] Use TCA and db defaults for auto-created redirect

Stefan Bürk CR +2 V +2 Normal +78 −70 updated 01/29/24, 11:43

Commit message

This change gathers the default values for a redirect
from the definied TCA and uses the database schema as
fallback and use it for the auto-created redirects as
default before applying the SiteConfiguration setting,
manual defaults and dispatching the redirect event
`ModifyAutoCreateRedirectRecordBeforePersistingEvent`.

Reduces the need to implement a event listener when
the `sys_redirect` table is extended with not nullable
columns to ensure proper default value handling unknown
to the redirects slugservice.

Further superflous properties are removed in the
SlugService and remaining properties get native
types donated.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Stefan Bürk uploaded patch set 1 01/26/24, 10:48

  2. Stefan Bürk uploaded patch set 2 01/26/24, 10:52

  3. core-ci voted on patch set 1 V -1 01/26/24, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52230

  4. core-ci voted on patch set 2 V -1 01/26/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52231

  5. Stefan Bürk uploaded patch set 3 V -1 01/26/24, 11:16

  6. core-ci voted on patch set 3 V +1 01/26/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52233

  7. Stefan Bürk rebased onto patch set 4 V +1 01/26/24, 12:47

  8. core-ci voted on patch set 4 V +1 01/26/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52248

  9. Oliver Klee voted on patch set 4 V +1 01/27/24, 13:37

  10. Guido Schmechel commented on patch set 4 CR +1 V +1 01/27/24, 20:12

    Successfully tested with respect_query_parameters via a TCA change. target_statuscode did not run via TCA because there is a separate setting for it: $this->httpStatusCode = (int)$settings->get('redirects.httpStatusCode', 307); Do we need to mention this in your new comment?
  11. Stefan Bürk uploaded patch set 5 CR +1 V +1 01/27/24, 20:58

  12. Stefan Bürk commented on patch set 4 01/27/24, 21:01

    Reply

    Removed the comment as it is solved by this change. It's mentioned in the commit message > before applying the SiteConfiguration setting, manual defaults and dispatching the redirect event `ModifyAutoCreateRedirectRecordBeforePersistingEvent`
  13. core-ci voted on patch set 5 V +1 01/27/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52330

  14. Oliver Klee voted on patch set 5 V +1 01/27/24, 21:08

  15. Guido Schmechel voted on patch set 5 CR +1 V +1 01/27/24, 21:37

  16. Oliver Klee voted on patch set 5 CR +1 01/27/24, 21:45

  17. Nikita Hovratov voted on patch set 5 CR +1 V +1 01/28/24, 16:58

  18. Stefan Bürk voted on patch set 5 CR +2 V +2 01/29/24, 11:43

  19. Stefan Bürk merged patch set 6 01/29/24, 11:43