Review main Merged

82659[TASK] Move 'extension download' upgrade wizard to EM

Christian Kuhn CR +2 V +2 Normal +186 −58 updated 01/26/24, 15:31

Commit message

The install tool has just a few dependencies to
ext:extensionmanager. Most notably, it ships the
AbstractDownloadExtensionUpdate upgrade wizard,
which is used when core extracts stuff to dedicated
extensions that are removed from monorepo.

The v12 upgrade wizard for 'fe_login_mode' uses this.

These upgrade wizards are tailored for non-composer-mode
only, just like the extensionmanager, which essentially
does nothing in composer mode.

To loosen the dependency from ext:install to
ext:extensionmanager, the patch moves the abstract, a
model class for this case, plus the fe_login_mode
implementation to ext:extensionmanager.

Class aliases are established, so a casual deprecation
is enough in this case. A few extensions rely on the
class, typically those that try to extend the upgrade
range of core by forward porting wizards older than
two major core versions. Those shoud continue to work
with v13, and will have to adapt the class namespace
of the abstract with v14 latest.

Moving the fe_login_mode wizard around does not make the
wizard show up again in case the wizard has been marked
'done' during v12 upgrade already, since usually the
according DB field does not exist anymore. We don't need
special handling for this case.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1115

  1. Christian Kuhn uploaded patch set 1 01/26/24, 11:55

  2. Christian Kuhn uploaded patch set 2 01/26/24, 12:01

  3. core-ci voted on patch set 1 V -1 01/26/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52239

  4. core-ci voted on patch set 2 V +1 01/26/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52240

  5. Christian Kuhn uploaded patch set 3 V +1 01/26/24, 12:32

  6. core-ci voted on patch set 3 V +1 01/26/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52247

  7. Benni Mack voted on patch set 3 CR +1 V +1 01/26/24, 13:13

  8. Andreas Kienast commented on patch set 3 01/26/24, 13:54

    ExtensionModel.php:26

    In theory, this is a breaking change as the extending class must explicitly made `readonly` now as well: ```shell php > readonly class Foo {}; php > class Bar extends Foo {}; PHP Fatal error: Non-readonly class Bar cannot extend readonly class Foo in php shell code on line 1 ```
  9. Christian Kuhn commented on patch set 3 01/26/24, 13:55

    ExtensionModel.php:26 Reply

    ah true that. will drop this.
  10. Christian Kuhn uploaded patch set 4 CR +1 V +1 01/26/24, 13:57

  11. Christian Kuhn commented on patch set 3 01/26/24, 13:57

    ExtensionModel.php:26 Reply

    Done
  12. Andreas Kienast voted on patch set 4 CR +1 V +1 01/26/24, 13:58

  13. core-ci voted on patch set 4 V +1 01/26/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52258

  14. Nikita Hovratov voted on patch set 4 CR +2 V +2 01/26/24, 15:30

  15. Nikita Hovratov merged patch set 5 01/26/24, 15:31