82661[TASK] Reduce `ext_tables.sql` for `ext:redirects`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1723
-
Stefan Bürk uploaded patch set 1 01/26/24, 12:47
-
Stefan Bürk updated the commit message in patch set 2 01/26/24, 12:48
-
Stefan Bürk updated the commit message in patch set 3 01/26/24, 12:49
-
Stefan Bürk updated the commit message in patch set 4 01/26/24, 12:49
-
core-ci voted on patch set 1 V -1 01/26/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52249
-
core-ci voted on patch set 2 V -1 01/26/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52250
-
core-ci voted on patch set 3 V -1 01/26/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52251
-
core-ci voted on patch set 4 V -1 01/26/24, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52252
-
Guido Schmechel commented on patch set 4 V -1 01/27/24, 20:24
Unfortunately, I have had no success here. I removed both fields in the table and ran the DB Analyzer. target_statuscode was recognised correctly. Unfortunately, nothing was found for hitcount. I first suspected displayCond or readOnly, but manipulating them didn't work either. Do you have any other ideas? -
Stefan Bürk uploaded patch set 5
V -101/27/24, 20:58 -
Stefan Bürk commented on patch set 4 01/27/24, 20:59
Reply
nope - simple the fact that `TCA type=input` does not have auto schema creation based on pure TCA yet. Was an oversight. -
core-ci voted on patch set 5 V +1 01/27/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52331
-
Oliver Klee voted on patch set 5 CR +1 01/27/24, 21:18
-
Guido Schmechel commented on patch set 5 01/27/24, 21:35
Reply
Sorry. Tested a little too early :-D -
Guido Schmechel voted on patch set 5 CR +1 V +1 01/27/24, 21:36
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/27/24, 21:36
-
Stefan Bürk updated the commit message in patch set 6
CR +1V +101/28/24, 12:09 -
core-ci voted on patch set 6 V +1 01/28/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52359
-
Oliver Klee voted on patch set 6 CR +1 01/28/24, 12:17
-
Oliver Klee voted on patch set 6 V +1 01/28/24, 16:30
-
Christian Kuhn voted on patch set 6 CR +1 V +1 01/29/24, 12:36
-
Stefan Bürk voted on patch set 6 CR +2 V +2 01/29/24, 13:13
-
Stefan Bürk merged patch set 7 01/29/24, 13:13