Review main Merged

82661[TASK] Reduce `ext_tables.sql` for `ext:redirects`

Stefan Bürk CR +2 V +2 Easy +0 −2 updated 01/29/24, 13:13

Commit message

It's a generic goal to provide database scheme defaults
for TCA defined tables with the on-going #101553 quest.

For `ext:redirects` the `target_statuscode` field has
not been removed due to the database default value.

Meanwhile it is ensured with #102938 that not only the
DataHandler but also the auto-create using QueryBuilder
respects TCA and database defaults - albeit overriden
with a manual default and based on the SiteConfiguration.

Therefore, this entry is now removed along with the todo
comment from the `ext_tables.sql`. Core uses proper API's
which ensures keeping the same default - whereas extension
not using proper api could be trapped with the removed
database default.

Note: Removing the `source_*` fields and `hitcount`
is not possible right now due to the simple fact that
`type=input` not having default schema creation yet.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1723

  1. Stefan Bürk uploaded patch set 1 01/26/24, 12:47

  2. Stefan Bürk updated the commit message in patch set 2 01/26/24, 12:48

  3. Stefan Bürk updated the commit message in patch set 3 01/26/24, 12:49

  4. Stefan Bürk updated the commit message in patch set 4 01/26/24, 12:49

  5. core-ci voted on patch set 1 V -1 01/26/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52249

  6. core-ci voted on patch set 2 V -1 01/26/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52250

  7. core-ci voted on patch set 3 V -1 01/26/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52251

  8. core-ci voted on patch set 4 V -1 01/26/24, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52252

  9. Guido Schmechel commented on patch set 4 V -1 01/27/24, 20:24

    Unfortunately, I have had no success here. I removed both fields in the table and ran the DB Analyzer. target_statuscode was recognised correctly. Unfortunately, nothing was found for hitcount. I first suspected displayCond or readOnly, but manipulating them didn't work either. Do you have any other ideas?
  10. Stefan Bürk uploaded patch set 5 V -1 01/27/24, 20:58

  11. Stefan Bürk commented on patch set 4 01/27/24, 20:59

    Reply

    nope - simple the fact that `TCA type=input` does not have auto schema creation based on pure TCA yet. Was an oversight.
  12. core-ci voted on patch set 5 V +1 01/27/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52331

  13. Oliver Klee voted on patch set 5 CR +1 01/27/24, 21:18

  14. Guido Schmechel commented on patch set 5 01/27/24, 21:35

    Reply

    Sorry. Tested a little too early :-D
  15. Guido Schmechel voted on patch set 5 CR +1 V +1 01/27/24, 21:36

  16. Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/27/24, 21:36

  17. Stefan Bürk updated the commit message in patch set 6 CR +1 V +1 01/28/24, 12:09

  18. core-ci voted on patch set 6 V +1 01/28/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52359

  19. Oliver Klee voted on patch set 6 CR +1 01/28/24, 12:17

  20. Oliver Klee voted on patch set 6 V +1 01/28/24, 16:30

  21. Christian Kuhn voted on patch set 6 CR +1 V +1 01/29/24, 12:36

  22. Stefan Bürk voted on patch set 6 CR +2 V +2 01/29/24, 13:13

  23. Stefan Bürk merged patch set 7 01/29/24, 13:13