82665[!!!][TASK] Make Indexed Search a CType
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102985-DeclareIndexedSearchAsContentType.rstnew+68 −0
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+1 −1
- typo3/sysext/indexed_search/Configuration/TCA/Overrides/tt_content.php+1 −3
- typo3/sysext/indexed_search/ext_localconf.php+2 −1
- typo3/sysext/install/Classes/Updates/IndexedSearchCTypeMigration.php10new+210 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/IndexedSearchBase.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/IndexedSearchMigrated.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/IndexedSearchPartiallyMigrated.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/IndexedSearchCTypeMigrationTest.phpnew+82 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/GeneratorFrontend.php+1 −2
Review log 1826
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 01/27/24, 00:53
-
core-ci voted on patch set 1 V -1 01/27/24, 00:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52278
-
Oli Bartsch uploaded patch set 2
V -101/29/24, 15:26 -
core-ci voted on patch set 2 V -1 01/29/24, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52433
-
Oli Bartsch uploaded patch set 3
V -101/29/24, 15:38 -
core-ci voted on patch set 3 V -1 01/29/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52434
-
Oli Bartsch uploaded patch set 4
V -101/29/24, 17:24 -
core-ci voted on patch set 4 V -1 01/29/24, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52449
-
Oli Bartsch uploaded patch set 5
V -101/29/24, 17:53 -
core-ci voted on patch set 5 V -1 01/29/24, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52450
-
Oli Bartsch uploaded patch set 6
V -101/29/24, 18:02 -
core-ci voted on patch set 6 V +1 01/29/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52451
-
Stefan Bürk commented on patch set 6 01/29/24, 18:33
IndexedSearchCTypeMigration.php:134array spread operator superflous - just use the fields directly.IndexedSearchCTypeMigration.php:158Using quote for the like syntax is not a good way. This should be used with `createNamedParameter()` and a `escapeLikeWildcards()` https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Database/QueryBuilder/Index.html#escapelikewildcards So, I would suggest to use here: ```php $queryBuilder->expr()->like( 'explicit_allowdeny', $queryBuilder->createNamedParameter( '%'. $queryBuilder->escapeLikeWildcards( 'tt_content:list_type:indexedsearch_pi2' ) . '%' ) ), ``` Note: line break only related for gettir comment.IndexedSearchCTypeMigration.php:166Can't we inject the connection pool in the constructor ?IndexedSearchCTypeMigration.php:208Isn't this method unused ? TBH this is not "cross-dbmns" safe - as `"` is not the identifier quoting for all database platforms. @see https://github.com/TYPO3/typo3/blob/0d516c851584e58d8ea5ad3e25c7663a5a79186f/typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php#L1925-L1928 ``` private function trimIdentifierQuotes(string $identifier): string { return str_replace(['`', '"', '[', ']'], '', $identifier); } ``` -
Oli Bartsch uploaded patch set 7
V +101/29/24, 19:52 -
Oli Bartsch commented on patch set 7 01/29/24, 19:52
IndexedSearchCTypeMigration.php:129ReplyDoneIndexedSearchCTypeMigration.php:134ReplyDoneIndexedSearchCTypeMigration.php:158ReplyDoneIndexedSearchCTypeMigration.php:166ReplyDoneIndexedSearchCTypeMigration.php:208ReplyDone -
core-ci voted on patch set 7 V +1 01/29/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52462
-
Benni Mack voted on patch set 7 CR +1 01/29/24, 20:47
-
Nikita Hovratov uploaded patch set 8
CR +1V +101/29/24, 20:59 -
Stefan Bürk voted on patch set 8 CR +1 V +1 01/29/24, 21:02
-
Stefan Bürk commented on patch set 8 01/29/24, 21:03
thanks for taking care and nikita for the further findings. -
core-ci voted on patch set 8 V +1 01/29/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52465
-
Nikita Hovratov commented on patch set 8 CR +1 V +1 01/29/24, 21:08
Just as side note: The Content Element "General Plugin (CType: list)" is now unused with this patch, as it has no list_type entries anymore. We should consider adding a logic, which hides this element from the wizard and type select if it has no entries. Someday we can hopefully remove it completely. -
Benni Mack voted on patch set 8 CR +1 V +1 01/29/24, 21:31
-
Oli Bartsch voted on patch set 8 CR +2 V +2 01/29/24, 21:46
-
Oli Bartsch merged patch set 9 01/29/24, 21:46
-
Oli Bartsch commented on patch set 9 01/29/24, 22:10
Reply
Pushed a patch for it https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704
IndexedSearchCTypeMigration.php:129