Review main Merged

82667[TASK] Stop exposing the internal AbstractFileFolder class

Oliver Klee CR +2 V +2 Easy +12 −6 updated 01/27/24, 18:42

Commit message

The abstract class `AbstractFileFolder` is broken by design as it
tries to abstract the `originalResource` property while this
property is relied on the have specific different types in
subclasses.

This is a pre-patch to get rid of this class and use clean native
type declarations in the subclasses.

As all affected classes are internal, this change is non-breaking.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 914

  1. Oliver Klee uploaded patch set 1 01/27/24, 11:45

  2. Oliver Klee updated the commit message in patch set 2 01/27/24, 11:47

  3. Oliver Klee updated the commit message in patch set 3 01/27/24, 11:51

  4. Oliver Klee updated the commit message in patch set 4 01/27/24, 11:51

  5. core-ci voted on patch set 1 V +1 01/27/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52287

  6. core-ci voted on patch set 2 V +1 01/27/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52289

  7. core-ci voted on patch set 3 V +1 01/27/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52290

  8. core-ci voted on patch set 4 V +1 01/27/24, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52291

  9. Simon Schaufelberger uploaded patch set 5 V +1 01/27/24, 13:06

  10. Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/27/24, 13:06

  11. core-ci voted on patch set 5 V +1 01/27/24, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52295

  12. Oliver Klee wrote 01/27/24, 13:32

    Topic set to extbase
  13. Christian Kuhn voted on patch set 5 CR +2 V +2 01/27/24, 18:41

  14. Christian Kuhn merged patch set 6 01/27/24, 18:42