Review main Merged Breaking

82671[!!!][TASK] Add native types to (Lazy)ObjectStorage

Oliver Klee CR +2 V +2 Normal +45 −75 updated 01/29/24, 12:41

Commit message

Also fix the PHPDoc annotations and generics along the way
to avoid introducing (valid) PHPStan warnings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Oliver Klee uploaded patch set 1 01/27/24, 15:40

  2. Oliver Klee wrote 01/27/24, 15:40

    Topic set to extbase
  3. Oliver Klee uploaded patch set 2 01/27/24, 15:42

  4. core-ci voted on patch set 1 V +1 01/27/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52303

  5. core-ci voted on patch set 2 V +1 01/27/24, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52304

  6. Oliver Klee commented on patch set 2 CR -1 01/27/24, 17:11

    Let's get https://review.typo3.org/c/Packages/TYPO3.CMS/+/82673 merged first so the backport will be less of a hassle.
  7. Oliver Klee uploaded patch set 3 CR -1 V +1 01/27/24, 18:48

  8. core-ci voted on patch set 3 V +1 01/27/24, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52314

  9. Oliver Klee commented on patch set 3 CR -1 01/27/24, 19:56

    Still blocked by the pre-patch.
  10. Oliver Klee uploaded patch set 4 CR -1 V +1 01/28/24, 12:56

  11. core-ci voted on patch set 4 V +1 01/28/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52363

  12. Oliver Klee uploaded patch set 5 V +1 01/28/24, 13:30

  13. core-ci voted on patch set 5 V +1 01/28/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52365

  14. Nikita Hovratov voted on patch set 5 CR +1 V +1 01/28/24, 16:43

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 01/29/24, 12:41

  16. Christian Kuhn merged patch set 6 01/29/24, 12:41