Review main Merged

82685[BUGFIX] Add missing type in annotation for GU::implodeAttributes

Oliver Klee CR +2 V +2 Easy +1 −1 updated 01/28/24, 11:13

Commit message

Attributes provided to this method can also have integer values
(which makes the `string` cast in the method necessary).

The PHPDoc type annotations should reflect that to avoid false
positives when calling code is statically analyzed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Klee uploaded patch set 1 01/28/24, 09:57

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 01/28/24, 09:59

  3. core-ci voted on patch set 1 V +1 01/28/24, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52349

  4. Guido Schmechel voted on patch set 1 CR +1 V +1 01/28/24, 10:29

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/28/24, 11:13

  6. Christian Kuhn merged patch set 2 01/28/24, 11:13