Review main Merged Breaking

82690[!!!][TASK] Declare EXT:workspaces classes internal

Christian Kuhn CR +2 V +2 Normal +99 −1 updated 01/28/24, 20:09

Commit message

To get some more details of EXT:workspaces right, the
core needs some freedom when refactoring classes.
Most of the workspaces "application" is obviously
@internal, extensions must not tamper with this,
or should be aware that details are not considered
public API, except - of course - dispatched events.

Future development in this area will sharpen the
current mix-up of EXT:core related workspace code,
and code located within EXT:workspaces, by moving
things around.

The patch adds a few `@internal` declarations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/28/24, 14:59

  2. core-ci voted on patch set 1 V +1 01/28/24, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52371

  3. Oliver Klee voted on patch set 1 CR +1 V +1 01/28/24, 16:30

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 01/28/24, 16:30

  5. Oliver Klee voted on patch set 2 CR +1 V +1 01/28/24, 16:30

  6. Nikita Hovratov voted on patch set 2 CR +1 V +1 01/28/24, 16:34

  7. core-ci voted on patch set 2 V +1 01/28/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52372

  8. Benni Mack voted on patch set 2 CR +2 V +2 01/28/24, 20:09

  9. Benni Mack merged patch set 3 01/28/24, 20:09