Review main Merged Breaking

82694[!!!][TASK] Add getAllPageNumbers() to PaginationInterface

Christian Kuhn CR +2 V +2 Normal +52 −2 updated 01/29/24, 13:54

Commit message

The PaginationInterface contains the basic set of
methods a pagination provides. The interface has
been introduced with #89603, later, #93340 added
getAllPageNumbers() to SimplePagination, and
issue #94625 picked that up in SlidingWindowPagination.

The patch adds the method to the interface to be
generally available.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/29/24, 13:24

  2. core-ci voted on patch set 1 V +1 01/29/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52414

  3. Stefan Bürk commented on patch set 2 V +1 01/29/24, 13:33

    Published edit on patch set 1.
  4. Stefan Bürk voted on patch set 2 CR +1 V +1 01/29/24, 13:34

  5. core-ci voted on patch set 2 V +1 01/29/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52415

  6. Oliver Klee voted on patch set 2 CR +1 V +1 01/29/24, 13:41

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/29/24, 13:54

  8. Christian Kuhn merged patch set 3 01/29/24, 13:54