Review main Merged

82697[TASK] Replace general tab label with more specific version

Nikita Hovratov CR +2 V +2 Easy +2 −5 updated 01/29/24, 17:21

Commit message

There are two identical labels for the FormEngine general tab. This is
the default tab, if no first tab is defined explicitly. Use the more
specific version in Form/locallang_tabs.xlf and drop the other label
bundled randomly into locallang_core.xlf.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Nikita Hovratov uploaded patch set 1 01/29/24, 15:51

  2. Christian Kuhn commented on patch set 1 CR -1 01/29/24, 15:55

    there is a second usage in the same file ...
  3. core-ci voted on patch set 1 V +1 01/29/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52438

  4. Nikita Hovratov uploaded patch set 2 CR -1 V +1 01/29/24, 16:11

  5. Nikita Hovratov commented on patch set 2 01/29/24, 16:11

    Reply

    thanks :)
  6. core-ci voted on patch set 2 V +1 01/29/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52440

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 01/29/24, 16:22

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 01/29/24, 17:20

  9. Stefan Bürk merged patch set 3 01/29/24, 17:21