Review main Merged

82701[BUGFIX] Prevent side effects in rst extension scanner tags check

Oli Bartsch CR +2 V +2 Normal +48 −17 updated 01/30/24, 12:59

Commit message

There might be no comma in front of an extension
scanner tag. This should not lead to an error as
it's unrelated for this check and will already be
catched by the "validateLastLine" check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1215

  1. Oli Bartsch uploaded patch set 1 01/29/24, 19:46

  2. core-ci voted on patch set 1 V +1 01/29/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52461

  3. Stefan Bürk commented on patch set 1 CR -1 01/29/24, 22:10

    This would also validate following as valid (before this change it was invalid): ``` .. index:: Backend, JavaScriptNotScanned, ext:core ```
  4. Oli Bartsch uploaded patch set 2 CR -1 V +1 01/29/24, 22:25

  5. Oli Bartsch commented on patch set 2 01/29/24, 22:25

    Reply

    Please try again.
  6. core-ci voted on patch set 2 V +1 01/29/24, 22:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52469

  7. Stefan Bürk commented on patch set 2 CR +1 V +1 01/30/24, 08:43

    Reply

    Thx.
  8. Simon Schaufelberger commented on patch set 2 V -1 01/30/24, 09:18

    there is also a test script. please cover with a test.
  9. Oli Bartsch uploaded patch set 3 CR +1 V +1 01/30/24, 09:47

  10. Oli Bartsch commented on patch set 3 01/30/24, 09:47

    Reply

    Done
  11. core-ci voted on patch set 3 V +1 01/30/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52487

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/30/24, 11:38

  13. Stefan Bürk voted on patch set 3 CR +1 V +1 01/30/24, 12:46

  14. Oli Bartsch voted on patch set 3 CR +2 V +2 01/30/24, 12:58

  15. Oli Bartsch merged patch set 4 01/30/24, 12:59