82701[BUGFIX] Prevent side effects in rst extension scanner tags check
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Scripts/test/rstFiles/data/test4/Changelog/master/Deprecation-12345-Test4-1.rstnew+14 −0
- Build/Scripts/test/rstFiles/data/test4/Changelog/master/Deprecation-12345-Test4-2.rstnew+16 −0
- Build/Scripts/test/rstFiles/data/test4/Changelog/master/Deprecation-12345-Test4-3.rstrenamed+1 −1
- Build/Scripts/test/rstFiles/data/test4/Changelog/master/Deprecation-12345-Test4-5.rstnew+16 −0
- Build/Scripts/test/rstFiles/data/test6/Changelog/master/Feature-12345-Test6.rstdeleted+0 −15
- Build/Scripts/validateRstFiles.php+1 −1
Review log 1215
-
Oli Bartsch uploaded patch set 1 01/29/24, 19:46
-
core-ci voted on patch set 1 V +1 01/29/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52461
-
Stefan Bürk commented on patch set 1 CR -1 01/29/24, 22:10
This would also validate following as valid (before this change it was invalid): ``` .. index:: Backend, JavaScriptNotScanned, ext:core ``` -
Oli Bartsch uploaded patch set 2
CR -1V +101/29/24, 22:25 -
Oli Bartsch commented on patch set 2 01/29/24, 22:25
Reply
Please try again. -
core-ci voted on patch set 2 V +1 01/29/24, 22:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52469
-
Stefan Bürk commented on patch set 2 CR +1 V +1 01/30/24, 08:43
Reply
Thx. -
Simon Schaufelberger commented on patch set 2 V -1 01/30/24, 09:18
there is also a test script. please cover with a test. -
Oli Bartsch uploaded patch set 3
CR +1V +101/30/24, 09:47 -
Oli Bartsch commented on patch set 3 01/30/24, 09:47
Reply
Done -
core-ci voted on patch set 3 V +1 01/30/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52487
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/30/24, 11:38
-
Stefan Bürk voted on patch set 3 CR +1 V +1 01/30/24, 12:46
-
Oli Bartsch voted on patch set 3 CR +2 V +2 01/30/24, 12:58
-
Oli Bartsch merged patch set 4 01/30/24, 12:59