Review main Merged

82703[TASK] Remove Content Element "General Plugin" when no list_type defined

Nikita Hovratov CR +2 V +2 Normal +128 −0 updated 01/30/24, 07:42

Commit message

A new event listener for the ModifyContentElementWizardItem Event is
added to check for `list_type` items. If no list types are defined,
the related wizard item `plugins_list` is removed from the wizard as it
has no functionality alone.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1318

  1. Nikita Hovratov uploaded patch set 1 01/29/24, 21:49

  2. core-ci voted on patch set 1 V +1 01/29/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52466

  3. Nikita Hovratov uploaded patch set 2 V +1 01/29/24, 21:57

  4. core-ci voted on patch set 2 V +1 01/29/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52467

  5. Stefan Bürk commented on patch set 2 01/29/24, 22:03

    I'd say we shoult somehow mention this for extension authors that registers for the same event to add a `before` for this wizard. Or maybe not doing it as event at all ? What do you think ?
  6. Nikita Hovratov commented on patch set 2 01/29/24, 22:10

    Reply

    I didn't want to hard-code this into EXT:backend as it shouldn't have knowledge about concrete item identifiers, so the event comes in handy. The only problem would be the (too early) removal of the plugin group right? I already mentioned the todo to add the removal after the event. I could provide this patch first.
  7. Stefan Bürk commented on patch set 2 01/29/24, 22:12

    Reply

    I know - and that was the reason I asked if we should mention this somehow. For example as a `Important Restfile` ? What do you think ?
  8. Oli Bartsch commented on patch set 2 01/29/24, 22:13

    Reply

    Please have a look at my patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704 Let's remove the category in the controller.

    RemoveListTypePluginFromNewContentElementWizard.php:32

    Let's get the subtype_value_field dynamically from the types configuration. Have a look at my patch if you like https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704.
  9. Nikita Hovratov uploaded patch set 3 V +1 01/29/24, 22:45

  10. Nikita Hovratov commented on patch set 2 01/29/24, 22:45

    Reply

    As discussed with Oli, we will do this in his patch as pre-patch.

    RemoveListTypePluginFromNewContentElementWizard.php:32 Reply

    Done
  11. core-ci voted on patch set 3 V +1 01/29/24, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52470

  12. Nikita Hovratov rebased onto patch set 4 V +1 01/29/24, 22:56

  13. Nikita Hovratov updated the commit message in patch set 5 01/29/24, 23:01

  14. core-ci voted on patch set 4 V +1 01/29/24, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52473

  15. core-ci voted on patch set 5 V +1 01/29/24, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52475

  16. Oli Bartsch voted on patch set 5 CR +1 V +1 01/30/24, 07:42

  17. Benni Mack voted on patch set 5 CR +2 V +2 01/30/24, 07:42

  18. Benni Mack merged patch set 6 01/30/24, 07:42