Review main Merged

82716[BUGFIX] Change file extension separator in element browser string

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 01/31/24, 07:31

Commit message

The element browser string (bparams), forwarding
different information between states is using the
pipe ("|") character as separator.

With #101231, this string got extended by also
respecting a "disallowed" file extension list,
next to the "allowed" list. Since this information
is stored as one part, an additional separator
";" was introduced.

However, this character now leads to problems,
depending on the used environment (see linked
references). To circumvent this, the separator
is changed to the "~" character for now, as
this is not a reserved character, according
to RFC3986.

In the long run, this string should anyways be
replaced by a more robust solution.

* https://github.com/traefik/traefik/issues/9164
* https://github.com/symfony/symfony/pull/51709
* https://datatracker.ietf.org/doc/html/rfc3986#section-2.2

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1315

  1. Oli Bartsch uploaded patch set 1 01/30/24, 11:05

  2. Simon Schaufelberger commented on patch set 1 01/30/24, 11:15

    would another character like tilde (~) even be better?
  3. core-ci voted on patch set 1 V +1 01/30/24, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52488

  4. Oli Bartsch commented on patch set 1 01/30/24, 11:15

    Reply

    Why?
  5. Garvin Hicking commented on patch set 1 CR +1 V +1 01/30/24, 11:16

    Thanks for taking care of it so quickly after getting reported. This fixes the issue for me in the ddev-traefik environment, too!
  6. Simon Schaufelberger commented on patch set 1 01/30/24, 11:21

    Reply

    Just wanted to ask if there might be other problems with colon coming up. I'm not familiar with RFCs or so...
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 01/30/24, 12:44

  8. Oli Bartsch commented on patch set 2 01/30/24, 12:44

    Reply

    ACK, changed it as ":" is indeed a reserved character, according to https://datatracker.ietf.org/doc/html/rfc3986#section-2.2
  9. core-ci voted on patch set 2 V +1 01/30/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52491

  10. Garvin Hicking commented on patch set 2 CR +1 V +1 01/30/24, 12:56

    Works with ~ for me, thanks! (There are some irregularities in the RFC whether "~" must be URL-encoded or not. Voting for using this as-is and reworking in case some webservers or proxies choke on it. It sure is an improvement compared with the current traefik-breaking implementation.)
  11. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/30/24, 13:04

  12. Benjamin Franzke commented on patch set 2 CR +1 V +1 01/31/24, 07:17

    As I've already explained in https://review.typo3.org/c/Packages/TYPO3.CMS/+/80171 this is our fault by not applying proper encoding, last time it was our JS, not it is our backend code because symfony is too dumb to understand how to properly encode URL parameters. You correctly linked that issue. Therefore this is good to go, since we *have* to workaround the broken symfony url encoder – but this is really unsatisfying.
  13. Benjamin Franzke voted on patch set 2 CR +2 V +2 01/31/24, 07:24

  14. Benjamin Franzke merged patch set 3 01/31/24, 07:31

  15. Georg Ringer voted on patch set 2 CR +1 V +1 01/31/24, 07:31