82717[BUGFIX] Ensure database port as int in setup command
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1113
-
Benjamin Franzke uploaded patch set 1 01/30/24, 12:35
-
core-ci voted on patch set 1 V +1 01/30/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52490
-
Oli Bartsch voted on patch set 1 CR +1 V +1 01/30/24, 12:46
-
Stefan Bürk voted on patch set 1 CR -1 01/30/24, 14:00
-
Stefan Bürk commented on patch set 1 01/30/24, 14:11
I guess we could also ensure that a little bit higher, in `SetupDatabaseService::getDriverOptions()` ... L600, L632, L669 Nikita already provided a patch for normal usages, however the reason it reoccurs is the fact that the setup command / service does collect these informations an writes it - but using the same not normalized information to boostrap the connection by writing on the fly to the global array. Will look for further points, but I guess that would be the curical point here .. going to push at a later point. -
Stefan Bürk uploaded patch set 2
CR +1V +101/30/24, 14:29 -
Stefan Bürk voted on patch set 2 CR +1 V +1 01/30/24, 14:30
-
Stefan Bürk commented on patch set 2 01/30/24, 14:30
Reply
Done -
core-ci voted on patch set 2 V +1 01/30/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52499
-
Benjamin Franzke voted on patch set 2 CR +1 V +1 01/30/24, 14:35
-
Oli Bartsch voted on patch set 2 CR +1 V +1 01/30/24, 14:45
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 01/30/24, 14:51
-
Benjamin Franzke merged patch set 3 01/30/24, 14:51