Review main Merged

82719[BUGFIX] Streamline absolute path handling in GU:getFileAbsFileName

TYPO3com CR +2 V +2 Easy +1 −2 updated 01/23/25, 14:21

Commit message

The widely used GeneralUtility::getFileAbsFileName method implemented
its own check if the absolute path should be allowed to be accessed.
It did not take the setting BE.lockRootPath into account.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1730

Show 15 earlier messages
  1. TYPO3com uploaded patch set 1 01/30/24, 14:06

  2. core-ci voted on patch set 1 V +1 01/30/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52498

  3. Oliver Hader updated the commit message in patch set 2 V +1 03/15/24, 11:08

  4. core-ci voted on patch set 2 V -1 03/15/24, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54581

  5. core-ci commented on patch set 2 03/15/24, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54581

  1. Oliver Hader rebased onto patch set 3 V -1 03/15/24, 11:40

  2. core-ci voted on patch set 3 V +1 03/15/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54585

  3. Oliver Hader rebased onto patch set 4 V +1 03/15/24, 17:56

  4. core-ci voted on patch set 4 V +1 03/15/24, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54603

  5. Oliver Hader rebased onto patch set 5 V +1 06/26/24, 12:11

  6. core-ci voted on patch set 5 V -1 06/26/24, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60381

  7. Oliver Hader rebased onto patch set 6 V -1 06/26/24, 12:20

  8. core-ci voted on patch set 6 V +1 06/26/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60382

  9. Benni Mack updated the commit message in patch set 7 V +1 10/18/24, 13:36

  10. core-ci voted on patch set 7 V -1 10/18/24, 22:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67999

  11. Benni Mack rebased onto patch set 8 V -1 11/19/24, 12:26

  12. core-ci voted on patch set 8 V +1 11/19/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69697

  13. Oliver Hader commented on patch set 8 11/19/24, 14:03

    GeneralUtility.php:2462

    I guess(!) the check for `vfs://` could be removed? In addition, now `PathUtility::isAllowedAdditionalPath($path)` would be allowed when invoking `GeneralUtility::getFileAbsFileName()` - which seems to be fine.
  14. Benni Mack rebased onto patch set 9 V +1 12/17/24, 16:57

  15. core-ci voted on patch set 9 V +1 12/17/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71301

  16. Christian Kuhn commented on patch set 9 01/07/25, 12:58

    GeneralUtility.php:2462 Reply

    the vfs check has been removed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/87299 in main.
  17. Benni Mack commented on patch set 9 01/22/25, 12:11

    GeneralUtility.php:2462 Reply

    Done
  18. Benni Mack voted on patch set 9 CR +1 01/22/25, 12:12

  19. Oliver Hader rebased onto patch set 10 CR +1 V +1 01/23/25, 13:49

  20. core-ci voted on patch set 10 V +1 01/23/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72929

  21. Oliver Hader rebased onto patch set 11 V +1 01/23/25, 14:11

  22. Oliver Hader voted on patch set 11 CR +1 V +1 01/23/25, 14:16

  23. core-ci voted on patch set 11 V +1 01/23/25, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72930

  24. Oliver Hader voted on patch set 11 CR +2 V +2 01/23/25, 14:21

  25. Oliver Hader merged patch set 12 01/23/25, 14:21