Review main Merged

82721[BUGFIX] Respect TCA type `group` as `foreign_selector`

Oli Bartsch CR +2 V +2 Hard +517 −8 updated 02/14/24, 07:28

Commit message

It's now possible to use a TCA type `group`
field as `foreign_selector` together with
the `useCombination` functionality. The
corresponding "child child table" information
is in this case fetched from the `allowed`
option.

Side note: Using TCA type `group` for a
`foreign_selector` field is not really
documented, but it's also not forbidden.
Actually, it's a valid use case and also
working quite well as the new styleguide
examples demonstrate.

However, the documentation should be adjusted
to mention that only one table can be defined
in `allowed` for such fields.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1522

  1. Oli Bartsch uploaded patch set 1 01/30/24, 16:47

  2. Oli Bartsch updated the commit message in patch set 2 01/30/24, 16:49

  3. core-ci voted on patch set 1 V -1 01/30/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52502

  4. core-ci voted on patch set 2 V -1 01/30/24, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52503

  5. Oli Bartsch uploaded patch set 3 V -1 01/30/24, 16:59

  6. core-ci voted on patch set 3 V +1 01/30/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52505

  7. Anja Leichsenring commented on patch set 3 01/31/24, 07:01

    the implementation seems rather unrelated to the forge issue mentioned, which is for type='group' and the missing 'parent_table' field. So I miss some context here, what was the issue you fixed? Please help out.
  8. Anja Leichsenring commented on patch set 3 01/31/24, 07:04

    Reply

    okay understood, the foreign_selector is determined from the allowed option. Disregard my comment.
  9. Benjamin Franzke uploaded patch set 4 V +1 01/31/24, 07:39

  10. Mathias Brodala commented on patch set 3 01/31/24, 07:40

    Please add an Important.rst for this which once more emphasizes that this will not work with Extbase out of the box if only "allowed" is used. One must also set "foreign_table" and accept that only a single table can be "allowed".
  11. core-ci voted on patch set 4 V +1 01/31/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52537

  12. Oli Bartsch uploaded patch set 5 V +1 01/31/24, 13:14

  13. Oli Bartsch commented on patch set 5 01/31/24, 13:15

    Reply

    Done
  14. core-ci voted on patch set 5 V +1 01/31/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52556

  15. Oli Bartsch rebased onto patch set 6 V +1 02/06/24, 15:06

  16. core-ci voted on patch set 6 V +1 02/06/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52798

  17. Garvin Hicking uploaded patch set 7 V +1 02/13/24, 18:12

    ReST formatting minor wording
  18. core-ci voted on patch set 7 V +1 02/13/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53178

  19. Anja Leichsenring voted on patch set 7 CR +1 V +1 02/14/24, 05:30

  20. Benni Mack voted on patch set 7 CR +1 V +1 02/14/24, 06:50

  21. Oli Bartsch voted on patch set 7 CR +2 V +2 02/14/24, 07:28

  22. Oli Bartsch merged patch set 8 02/14/24, 07:28