82721[BUGFIX] Respect TCA type `group` as `foreign_selector`
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+18 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+17 −3
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-102904-UseTCAGroupFieldAsForeignSelector.rstnew+80 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombinationGroup.phpnew+114 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputDynamicTextWithRecordUid.php+1 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php+2 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/Generator.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup.phpnew+105 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup_child.phpnew+81 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup_mm.phpnew+94 −0
- typo3/sysext/styleguide/ext_tables.sql+4 −0
Review log 1522
-
Oli Bartsch uploaded patch set 1 01/30/24, 16:47
-
Oli Bartsch updated the commit message in patch set 2 01/30/24, 16:49
-
core-ci voted on patch set 1 V -1 01/30/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52502
-
core-ci voted on patch set 2 V -1 01/30/24, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52503
-
Oli Bartsch uploaded patch set 3
V -101/30/24, 16:59 -
core-ci voted on patch set 3 V +1 01/30/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52505
-
Anja Leichsenring commented on patch set 3 01/31/24, 07:01
the implementation seems rather unrelated to the forge issue mentioned, which is for type='group' and the missing 'parent_table' field. So I miss some context here, what was the issue you fixed? Please help out. -
Anja Leichsenring commented on patch set 3 01/31/24, 07:04
Reply
okay understood, the foreign_selector is determined from the allowed option. Disregard my comment. -
Benjamin Franzke uploaded patch set 4
V +101/31/24, 07:39 -
Mathias Brodala commented on patch set 3 01/31/24, 07:40
Please add an Important.rst for this which once more emphasizes that this will not work with Extbase out of the box if only "allowed" is used. One must also set "foreign_table" and accept that only a single table can be "allowed". -
core-ci voted on patch set 4 V +1 01/31/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52537
-
Oli Bartsch uploaded patch set 5
V +101/31/24, 13:14 -
Oli Bartsch commented on patch set 5 01/31/24, 13:15
Reply
Done -
core-ci voted on patch set 5 V +1 01/31/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52556
-
Oli Bartsch rebased onto patch set 6
V +102/06/24, 15:06 -
core-ci voted on patch set 6 V +1 02/06/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52798
-
Garvin Hicking uploaded patch set 7
V +102/13/24, 18:12ReST formatting minor wording -
core-ci voted on patch set 7 V +1 02/13/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53178
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 02/14/24, 05:30
-
Benni Mack voted on patch set 7 CR +1 V +1 02/14/24, 06:50
-
Oli Bartsch voted on patch set 7 CR +2 V +2 02/14/24, 07:28
-
Oli Bartsch merged patch set 8 02/14/24, 07:28