Review main Merged

82723[TASK] Add visually-hidden label to CheckboxToggleElement

Christian Rath-Ulrich CR +2 V +2 Easy +5 −2 updated 08/06/24, 10:38

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 3143

Show 1318 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 01/30/24, 20:47

  2. core-ci voted on patch set 1 V -1 01/30/24, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52520

  3. Guido Schmechel commented on patch set 1 01/30/24, 22:20

    Commit message: label vs. lable :-)
  4. Guido Schmechel commented on patch set 1 01/30/24, 22:21

    CheckboxToggleElement.php:161

    'label'
  5. Georg Ringer commented on patch set 1 01/30/24, 22:25

    label

    CheckboxToggleElement.php:183

    also please use hsc() to avoid xss
  6. Anja Leichsenring updated the commit message in patch set 2 V -1 01/31/24, 06:26

  7. core-ci voted on patch set 2 V -1 01/31/24, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52528

  8. Christian Rath-Ulrich updated the commit message in patch set 3 V -1 01/31/24, 08:58

  9. core-ci voted on patch set 3 V -1 01/31/24, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52544

  10. Christian Rath-Ulrich uploaded patch set 4 V -1 01/31/24, 10:24

  11. Christian Rath-Ulrich commented on patch set 4 01/31/24, 10:25

    Reply

    Done

    CheckboxToggleElement.php:161 Reply

    Done

    CheckboxToggleElement.php:183 Reply

    Done
  12. core-ci voted on patch set 4 V -1 01/31/24, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52551

  13. Christian Kuhn commented on patch set 4 01/31/24, 11:12

    how does this patch relate to this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82150 ?
  14. Christian Rath-Ulrich commented on patch set 4 01/31/24, 11:50

    Reply

    There is a small conflict but my changes solving another issue he is mainly reworking the old labels to a legend I am adding a sufficient label to the single toggle
  15. Christian Rath-Ulrich uploaded patch set 5 V -1 01/31/24, 15:53

  16. core-ci voted on patch set 5 V +1 01/31/24, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52560

  17. Albrecht Köhnlein commented on patch set 5 CR -1 01/31/24, 18:48

    CheckboxToggleElement.php:160

    I'm afraid this could cause PHP warnings in case the [label] does not exist. What about checking with `isset()` or use `$additionalInformation['fieldConf']['label'] ?? ''` to not run into warnings?

    CheckboxToggleElement.php:182

    I really welcome accessibility improvements, but is there a reason to provide the label in debug mode only? Why not render it for non-debug mode too?

    CheckboxToggleElement.php:186

    No need for this additional line
  18. Albrecht Köhnlein commented on patch set 5 01/31/24, 18:49

    Please clean up the mix of single `'` and double quotes `"`
  1. Christian Rath-Ulrich updated the commit message in patch set 6 CR -1 V +1 02/05/24, 12:17

  2. core-ci voted on patch set 6 V +1 02/05/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52722

  3. Christian Rath-Ulrich commented on patch set 6 02/05/24, 12:28

    Reply

    Done
  4. Albrecht Köhnlein commented on patch set 6 02/05/24, 14:15

    CheckboxToggleElement.php:182 Reply

    Sorry, my mistake. It's fine.
  5. Christian Rath-Ulrich uploaded patch set 7 V +1 02/07/24, 10:23

  6. Christian Rath-Ulrich commented on patch set 7 02/07/24, 10:28

    CheckboxToggleElement.php:160 Reply

    Done

    CheckboxToggleElement.php:186 Reply

    Done
  7. core-ci voted on patch set 7 V +1 02/07/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52843

  8. Jasmina Ließmann commented on patch set 7 06/24/24, 11:01

    I'm not sure whether simply adding the label text adds any value, because currently it results in the following code: ``` <div class="form-check form-switch"> <input type="checkbox" ... /> <label class="form-check-label" for="###"> [1]<span class="visually-hidden"> Page visible</span> </label> </div> ``` Wouldn't it make sense to use descriptive texts like "enabled/disabled" or "activated/deactivated"? Possibly for all users?
  9. Jasmina Ließmann commented on patch set 7 06/24/24, 11:05

    Reply

    As a supplement: Only admin users see the [0] and [1]. Without the patch there isn't any label text at all, with this patch editors see "Page visible" for both states.
  10. Christian Rath-Ulrich uploaded patch set 8 V +1 07/16/24, 13:34

  11. core-ci voted on patch set 8 V +1 07/16/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61638

  12. Christian Rath-Ulrich uploaded patch set 9 V +1 07/18/24, 17:14

  13. core-ci voted on patch set 9 V +1 07/18/24, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61753

  14. Jasmina Ließmann commented on patch set 9 07/18/24, 17:57

    Reply

    Resolved with latest patchset.
  15. Jasmina Ließmann updated the commit message in patch set 10 V +1 07/18/24, 18:58

  16. core-ci voted on patch set 10 V -1 07/18/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61758

  17. core-ci voted on patch set 10 V +1 07/18/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61758

  18. Michael Telgkamp commented on patch set 10 CR -1 07/23/24, 07:38

    CheckboxToggleElement.php:180

    To improve the accessibility the input should get the attribute `role="switch"`.

    CheckboxToggleElement.php:182

    Having the `role="switch"` would already announce the role of the element to assistive technologies. Thus, the label should not have the `Toggle` included, as it is available through the role. A static content for all elements should also be added at the end, so users of assistive technologies can skip it and have the important information available first.
  19. Christian Rath-Ulrich uploaded patch set 11 CR -1 V +1 08/05/24, 15:18

  20. Christian Rath-Ulrich commented on patch set 11 08/05/24, 15:26

    CheckboxToggleElement.php:180 Reply

    added the role

    CheckboxToggleElement.php:182 Reply

    removed the lable
  21. core-ci voted on patch set 11 V +1 08/05/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62854

  22. Michael Telgkamp voted on patch set 11 CR +1 V +1 08/06/24, 10:18

  23. Christian Kuhn voted on patch set 11 CR +1 V +1 08/06/24, 10:29

  24. Christian Kuhn voted on patch set 11 CR +2 V +2 08/06/24, 10:38

  25. Christian Kuhn merged patch set 12 08/06/24, 10:38