Review 12.4 Merged

82726[BUGFIX] Change file extension separator in element browser string

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 01/31/24, 07:31

Commit message

The element browser string (bparams), forwarding
different information between states is using the
pipe ("|") character as separator.

With #101231, this string got extended by also
respecting a "disallowed" file extension list,
next to the "allowed" list. Since this information
is stored as one part, an additional separator
";" was introduced.

However, this character now leads to problems,
depending on the used environment (see linked
references). To circumvent this, the separator
is changed to the "~" character for now, as
this is not a reserved character, according
to RFC3986.

In the long run, this string should anyways be
replaced by a more robust solution.

* https://github.com/traefik/traefik/issues/9164
* https://github.com/symfony/symfony/pull/51709
* https://datatracker.ietf.org/doc/html/rfc3986#section-2.2

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 01/31/24, 07:21

  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/31/24, 07:24

  3. core-ci voted on patch set 1 V +1 01/31/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52535

  4. Benjamin Franzke merged patch set 2 01/31/24, 07:31