Review 11.5 Merged

82729[TASK] Unblock argument passing in `Build/Scripts/runTests.sh`

Stefan Bürk CR +2 V +2 Normal +44 −32 updated 01/31/24, 10:26

Commit message

The first argument after processing defined options has been
stored into the variable `TEST_FILE`. This value was passed
to PHPUnit based commands as last argument, defining the test
case to execute (or a subset).

Removing this workaround and directly passing remaining options
to the command makes special arguments like `-e` obsolete and
unblocks more generic command passing.

This change removes this variable and passes all remaining
arguments after option processing directly to the PHPUnit
command and paves the way for future command improvements.

Note:   This makes the `-e` option basically obsolete, but
        is kept for now to minimize muscle memory issues.
        Using it will display a `deprecation` notice at the
        end of the script - so it gets recognized.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Stefan Bürk uploaded patch set 1 01/31/24, 10:07

  2. Stefan Bürk uploaded patch set 2 01/31/24, 10:10

  3. core-ci voted on patch set 1 V +1 01/31/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52547

  4. core-ci voted on patch set 2 V +1 01/31/24, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52548

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 01/31/24, 10:25

  6. Stefan Bürk merged patch set 3 01/31/24, 10:26