Review 12.4 Merged

82734[BUGFIX] Reset array keys after filtering available languages

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 01/31/24, 07:39

Commit message

To prevent PHP from encoding the numeric keys
of the available languages as string, which would
lead to JavaScript errors, `array_values` is now
applied to the filtered list of languages.

This resets the keys and therefore ensures a
continuous numeric sequence starting from 0.

Reference: https://www.php.net/manual/en/function.json-encode.php#refsect1-function.json-encode-notes

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/31/24, 07:28

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/31/24, 07:30

  3. core-ci voted on patch set 1 V +1 01/31/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52536

  4. Benjamin Franzke merged patch set 2 01/31/24, 07:39