Review main Merged

82736[TASK] Revert "[TASK] Add title and aria-label to clear input button"

Benjamin Franzke CR +2 V +2 Easy +1 −35 updated 01/31/24, 08:50

Commit message

This reverts commit dba95382f4b2306080ace62a75a68a1e7b44fb63.

Reason for revert:

* The close button has tabIndex -1 so no aria-label is needed.
  Note: aria-label would have been useful in combination with #102372,
  but that patch was reverted as well, because with think a clearing
  button is not needed for keyboard users that use keyboard shortcuts
  anyway.
* The patch introduced new inline JavaScript which we want to avoid,
  also writing into TYPO3.lang directly via inline JavaScript is not
  ideal.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5