Review main Merged

82753[DOCS] Remove outdated number from logicalAnd() and logicalOr() PHPdoc

Albrecht Köhnlein CR +2 V +2 Easy +4 −4 updated 02/02/24, 16:21

Commit message

The methods `logicalAnd()` and `logicalOr()` allow any number of
constraints as parameters. The outdated PHPdoc comment still said "two".

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Albrecht Köhnlein uploaded patch set 1 01/31/24, 19:21

  2. core-ci voted on patch set 1 V +1 01/31/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52561

  3. Oliver Klee voted on patch set 1 CR +1 V +1 01/31/24, 19:58

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 02/02/24, 12:11

    (Maybe label this as [TASK] or [DOCS] because I think it doesn't fully warant the bugfix label, because it has no actual code change impact?)
  5. Stefan Bürk commented on patch set 1 02/02/24, 14:32

    TBH - this is a [TASK] or [DOCS] - but a bugfix with no code line change is mysterious.
  6. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 02/02/24, 14:39

  7. Oliver Klee commented on patch set 2 02/02/24, 14:39

    Reply

    Done
  8. Oliver Klee voted on patch set 2 CR +1 V +1 02/02/24, 14:39

  9. core-ci voted on patch set 2 V +1 02/02/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52635

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 02/02/24, 15:14

  11. Stefan Bürk voted on patch set 2 CR +2 V +2 02/02/24, 16:14

  12. Stefan Bürk merged patch set 3 02/02/24, 16:21