Review main Merged

82755[BUGFIX] Omit click menu on icons in `browse` mode

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 02/05/24, 09:10

Commit message

The element browsers, such as file browser,
folder browser or the create folder browser
are rendering the FileList in the `browse`
mode. In this case the context menu component
is not loaded. This is correct, since using
the context menu inside the modal would lead
to various side effects.

Because the JS component is not loaded for
mentioned reasons, wrapping the icons with
the click menu needs to be omitted. This
otherwise leads to further side effect,
e.g. loading a second folder tree in the
create folder browser.

Therefore, this change now omits wrapping
the icon with then click menu when the
Filelist is used in the `browse` mode.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 02/01/24, 08:29

  2. core-ci voted on patch set 1 V +1 02/01/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52571

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/02/24, 12:19

    Verified working, fixes the reported issue for me
  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/02/24, 12:29

  5. Andreas Kienast voted on patch set 1 CR +1 02/02/24, 15:08

  6. Andreas Kienast voted on patch set 1 V +1 02/02/24, 15:12

  7. Oli Bartsch voted on patch set 1 CR +2 V +2 02/05/24, 09:10

  8. Oli Bartsch merged patch set 2 02/05/24, 09:10