82757[TASK] Increase test coverage of ImageViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ImageViewHelper/Folders/fileadmin/user_upload/ImageViewHelperFalTest.jpgcopiedbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ImageViewHelper/Folders/fileadmin/ImageViewHelperTest.jpgrenamedbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ImageViewHelper/fal_image.csvnew+32 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+203 −23
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+268 −50
Review log 1524
-
Simon Praetorius uploaded patch set 1 02/01/24, 10:39
-
core-ci voted on patch set 1 V -1 02/01/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52580
-
Simon Praetorius uploaded patch set 2
V -102/01/24, 13:03 -
core-ci voted on patch set 2 V -1 02/01/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52586
-
Simon Praetorius uploaded patch set 3
V -102/01/24, 14:43 -
core-ci voted on patch set 3 V -1 02/01/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52597
-
Simon Praetorius uploaded patch set 4
V -102/01/24, 15:12 -
core-ci voted on patch set 4 V -1 02/01/24, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52600
-
Simon Praetorius uploaded patch set 5
V -102/01/24, 15:29 -
core-ci voted on patch set 5 V -1 02/01/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52601
-
Simon Praetorius uploaded patch set 6
V -102/01/24, 15:38 -
core-ci voted on patch set 6 V +1 02/01/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52602
-
Simon Praetorius uploaded patch set 7
V +102/01/24, 16:09 -
core-ci voted on patch set 7 V +1 02/01/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52604
-
Simon Praetorius uploaded patch set 8
V +102/01/24, 17:42 -
core-ci voted on patch set 8 V -1 02/01/24, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52612
-
Simon Praetorius uploaded patch set 9
V -102/01/24, 17:51 -
core-ci voted on patch set 9 V +1 02/01/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52613
-
Simon Praetorius marked it ready for review 02/01/24, 17:57
-
Oliver Klee voted on patch set 9 V +1 02/01/24, 18:09
-
Oliver Klee commented on patch set 9 02/01/24, 18:10
Awesome, thanks! -
Garvin Hicking commented on patch set 9 CR +1 V +1 02/02/24, 12:03
Pure Gold. Thanks for improving the tests (and actually fixing that broken/wrong crop-input format). -
Benni Mack voted on patch set 9 CR +2 V +2 02/05/24, 07:20
-
Benni Mack merged patch set 10 02/05/24, 07:20