Review main Merged

82757[TASK] Increase test coverage of ImageViewHelper

Simon Praetorius CR +2 V +2 Hard +503 −73 updated 02/05/24, 07:20

Commit message

This patch should cover all of the arguments and variants both
<f:image /> and <f:uri.image /> offer to generate images in Fluid
templates.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1524

  1. Simon Praetorius uploaded patch set 1 02/01/24, 10:39

  2. core-ci voted on patch set 1 V -1 02/01/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52580

  3. Simon Praetorius uploaded patch set 2 V -1 02/01/24, 13:03

  4. core-ci voted on patch set 2 V -1 02/01/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52586

  5. Simon Praetorius uploaded patch set 3 V -1 02/01/24, 14:43

  6. core-ci voted on patch set 3 V -1 02/01/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52597

  7. Simon Praetorius uploaded patch set 4 V -1 02/01/24, 15:12

  8. core-ci voted on patch set 4 V -1 02/01/24, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52600

  9. Simon Praetorius uploaded patch set 5 V -1 02/01/24, 15:29

  10. core-ci voted on patch set 5 V -1 02/01/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52601

  11. Simon Praetorius uploaded patch set 6 V -1 02/01/24, 15:38

  12. core-ci voted on patch set 6 V +1 02/01/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52602

  13. Simon Praetorius uploaded patch set 7 V +1 02/01/24, 16:09

  14. core-ci voted on patch set 7 V +1 02/01/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52604

  15. Simon Praetorius uploaded patch set 8 V +1 02/01/24, 17:42

  16. core-ci voted on patch set 8 V -1 02/01/24, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52612

  17. Simon Praetorius uploaded patch set 9 V -1 02/01/24, 17:51

  18. core-ci voted on patch set 9 V +1 02/01/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52613

  19. Simon Praetorius marked it ready for review 02/01/24, 17:57

  20. Oliver Klee voted on patch set 9 V +1 02/01/24, 18:09

  21. Oliver Klee commented on patch set 9 02/01/24, 18:10

    Awesome, thanks!
  22. Garvin Hicking commented on patch set 9 CR +1 V +1 02/02/24, 12:03

    Pure Gold. Thanks for improving the tests (and actually fixing that broken/wrong crop-input format).
  23. Benni Mack voted on patch set 9 CR +2 V +2 02/05/24, 07:20

  24. Benni Mack merged patch set 10 02/05/24, 07:20