Review main Merged

82758[TASK] Move table definition merge to `SchemaMigrator`

Stefan Bürk CR +2 V +2 Normal +48 −21 updated 02/05/24, 12:23

Commit message

To give extensions the ability to change the expected
database schema, adding or changing columns of existing
TYPO3 Core tables or other extension tables,
`ext_tables.sql` of extension are read and taken as partial
table definitions.

All table definitions are merged at a later point in the
`ConnectionMigrator`, forcing proper handling of partial
table information.

This change moves the table definition merge process from
the `ConnectionMigrator` to the `SchemaMigrator` at the
earliest possible place to pave the way for further
code cleanups.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1216

  1. Stefan Bürk uploaded patch set 1 02/01/24, 11:27

  2. core-ci voted on patch set 1 V +1 02/01/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52581

  3. Stefan Bürk updated the commit message in patch set 2 V +1 02/01/24, 12:42

  4. core-ci voted on patch set 2 V +1 02/01/24, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52583

  5. Garvin Hicking uploaded patch set 3 V +1 02/01/24, 13:41

    Phrasing
  6. Garvin Hicking commented on patch set 3 CR +1 02/01/24, 13:41

    Looking good, couldn't test (yet)
  7. core-ci voted on patch set 3 V +1 02/01/24, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52591

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/02/24, 09:16

  9. Oliver Klee voted on patch set 3 CR +1 02/02/24, 09:25

  10. Stefan Bürk rebased onto patch set 4 CR +1 V +1 02/05/24, 11:52

  11. core-ci voted on patch set 4 V +1 02/05/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52718

  12. Oliver Klee voted on patch set 4 CR +1 02/05/24, 12:03

  13. Benni Mack voted on patch set 4 CR +1 V +1 02/05/24, 12:06

  14. Anja Leichsenring voted on patch set 4 CR +1 V +1 02/05/24, 12:22

  15. Stefan Bürk voted on patch set 4 CR +2 V +2 02/05/24, 12:23

  16. Stefan Bürk merged patch set 5 02/05/24, 12:23