82760[TASK] Simplify table handling in `DefaultTCASchema`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 3
Review log 2432
Show 47 earlier messages
-
Stefan Bürk uploaded patch set 1 02/01/24, 12:42
-
core-ci voted on patch set 1 V +1 02/01/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52584
-
Stefan Bürk rebased onto patch set 2
V +102/01/24, 13:41 -
core-ci voted on patch set 2 V +1 02/01/24, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52592
-
Stefan Bürk rebased onto patch set 3
V +102/05/24, 11:52 -
core-ci voted on patch set 3 V +1 02/05/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52719
-
Oliver Klee commented on patch set 3 02/05/24, 12:03
I still see a merge conflict here. Is that warning in Gerrit a false positive?
-
Stefan Bürk commented on patch set 3 02/05/24, 12:21
Reply
Nope. That's because this change has a relation-chain with 82758: [TASK] Move table definition merge to `SchemaMigrator` | https://review.typo3.org/c/Packages/TYPO3.CMS/+/82758 - and merging it without the parent change is not possible, and therefore the merge conflict. Will resolve magically after parent change is merged. -
Stefan Bürk commented on patch set 3 02/05/24, 12:24
Reply
see ;) -
Oliver Klee commented on patch set 3 02/05/24, 12:32
Reply
Ah, I see. Thanks for the explanation! -
Stefan Bürk rebased onto patch set 4 02/05/24, 12:38
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 4 V +1 02/05/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52724
-
Oliver Klee voted on patch set 4 V +1 02/05/24, 13:07
-
Oliver Klee voted on patch set 4 CR +1 02/05/24, 13:09
-
Christian Kuhn commented on patch set 4 02/05/24, 15:05
DefaultTcaSchema.php:25exception still needed or can be removed altogether? -
Christian Kuhn uploaded patch set 5
CR +1V +102/05/24, 15:05 -
Oliver Klee voted on patch set 5 CR +1 V +1 02/05/24, 15:06
-
core-ci voted on patch set 5 V +1 02/05/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52740
-
Stefan Bürk voted on patch set 5 CR -1 02/05/24, 15:56
-
Stefan Bürk commented on patch set 5 02/05/24, 16:02
DefaultTcaSchema.php:25ReplyI guess we need it still at least at one point, so I moved the exception throw to that place directly and still keep removing the old generic loop method. TBH - not sure if this can be hit or not. But that's the only place I think there is a change it can still happen that a table is not in the tables array already. -
Stefan Bürk uploaded patch set 6
CR +1V +102/05/24, 16:04 -
core-ci voted on patch set 6 V +1 02/05/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52743
-
Stefan Bürk rebased onto patch set 7
V +102/14/24, 08:41 -
core-ci voted on patch set 7 V +1 02/14/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53190
-
Oliver Klee commented on patch set 7 02/14/24, 12:15
SchemaMigrator.php:250At this point in the control flow, `$tables` can also have numeric keys, e.g., from line 246. I think this line here with the annotation is not necessary. -
Stefan Bürk commented on patch set 7 02/14/24, 12:32
DefaultTcaSchema.php:25ReplyDoneSchemaMigrator.php:250ReplyBefore the call it "could" be both, after mergeTableDefintions() it is string based only. Removed the docblock now. -
Stefan Bürk uploaded patch set 8
V +102/14/24, 12:32 -
core-ci voted on patch set 8 V +1 02/14/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53192
-
Oliver Klee voted on patch set 8 CR +1 V +1 02/14/24, 12:56
-
Christian Kuhn voted on patch set 8 CR +1 V +1 02/14/24, 13:59
-
Stefan Bürk voted on patch set 8 CR +2 V +2 02/14/24, 14:46
-
Stefan Bürk merged patch set 9 02/14/24, 14:46