82761[TASK] Use `podman` before `docker` in `Build/Scripts/runTests.sh`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1620
-
Stefan Bürk uploaded patch set 1 02/01/24, 17:15
-
Stefan Bürk uploaded patch set 2 02/01/24, 17:16
-
Oliver Klee updated the commit message in patch set 3 02/01/24, 17:17
-
Stefan Bürk uploaded patch set 4 02/01/24, 17:20
-
core-ci voted on patch set 2 V +1 02/01/24, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52609
-
core-ci voted on patch set 3 V +1 02/01/24, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52610
-
core-ci voted on patch set 4 V +1 02/01/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52611
-
Oliver Klee commented on patch set 4 02/01/24, 17:57
-
Stefan Bürk commented on patch set 4 02/01/24, 19:25
runTests.sh:267ReplyBasically you are right, this is about the runTests.sh - therefore this as sidechange is okay here. I would say that i'm nearly the only person using these switches anyway. so let's keep that here as sidechange. -
Oliver Klee voted on patch set 4 CR +1 02/01/24, 21:04
-
Garvin Hicking voted on patch set 4 CR +1 V +1 02/02/24, 12:22
-
Oliver Klee commented on patch set 4 CR -1 V +1 02/02/24, 12:30
We also should update the help text (which still says that `docker` is the default). -
Oliver Klee commented on patch set 5
CR +1V +102/02/24, 12:30Published edit on patch set 4. -
Oliver Klee commented on patch set 5 CR +1 V +1 02/02/24, 12:31
Reply
Done. -
core-ci voted on patch set 5 V +1 02/02/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52631
-
Christian Kuhn voted on patch set 5 CR +1 V +1 02/02/24, 14:45
-
Andreas Kienast commented on patch set 5 02/02/24, 15:32
runTests.sh:503What happens if `CONTAINER_BIN` remains an empty string, e.g. in case neither podman nor docker are installed? -
Stefan Bürk commented on patch set 5 02/02/24, 16:05
runTests.sh:503ReplyIf neither docker or podman is available, `runTests.sh` already states this early and break out: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82761/5/Build/Scripts/runTests.sh#b354 So this is safe but uses podman instead of docker if both are installed. if only docker is installed it uses docker. or tries to use the specified binary. -
Stefan Bürk voted on patch set 5 CR +2 V +2 02/02/24, 16:06
-
Stefan Bürk merged patch set 6 02/02/24, 16:21
runTests.sh:267