Review main Merged

82763[FEATURE] Introduce ModifyRedirectUrlValidationResultEvent PSR-14 event

Torben Hansen CR +2 V +2 Normal +171 −5 updated 04/30/24, 12:13

Commit message

The frontend login extension currently validates a given redirect URL
by ensuring, that the URL is either relative or the host is known to
TYPO3. In some scenarios, it might however be useful to allow a
redirect URL, which does not match the existing rules.

This change adds the `ModifyRedirectUrlValidationResultEvent` PSR-14
event, allowing developers to implement custom validation logic for
the redirect URL.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Nikita Hovratov +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1420

  1. Torben Hansen uploaded patch set 1 02/02/24, 07:57

  2. Torben Hansen uploaded patch set 2 02/02/24, 08:00

  3. core-ci voted on patch set 1 V +1 02/02/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52619

  4. core-ci voted on patch set 2 V -1 02/02/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52620

  5. Torben Hansen uploaded patch set 3 V -1 02/02/24, 08:13

  6. core-ci voted on patch set 3 V +1 02/02/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52621

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/02/24, 09:44

  8. Guido Schmechel voted on patch set 3 CR +1 02/21/24, 10:27

  9. Torben Hansen uploaded patch set 4 CR +1 V +1 02/27/24, 17:37

  10. core-ci voted on patch set 4 V -1 02/27/24, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53649

  11. Torben Hansen uploaded patch set 5 V -1 02/27/24, 17:47

  12. core-ci voted on patch set 5 V +1 02/27/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53653

  13. Torben Hansen uploaded patch set 6 V +1 04/27/24, 12:57

  14. core-ci voted on patch set 6 V +1 04/27/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56853

  15. Guido Schmechel voted on patch set 6 CR +1 04/28/24, 11:09

  16. Simon Schaufelberger voted on patch set 6 CR +1 V +1 04/29/24, 09:27

  17. Jörg Bösche voted on patch set 6 CR +1 04/30/24, 11:34

  18. Nikita Hovratov voted on patch set 6 CR +1 04/30/24, 11:36

  19. Georg Ringer voted on patch set 6 CR +2 V +2 04/30/24, 12:13

  20. Georg Ringer merged patch set 7 04/30/24, 12:13